Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to preCICE v3 #5

Closed
uekerman opened this issue May 19, 2023 · 3 comments
Closed

Port to preCICE v3 #5

uekerman opened this issue May 19, 2023 · 3 comments
Assignees
@LeonardWilleke

Comments

@uekerman
Copy link
Member

Let's only merge this, once we released v0.1.0.
We should then also change to a branching workflow with dedicated main and develop branches and make main the default.
@LeonardWilleke
Copy link
Collaborator

The runner was modified in branch port-v3 to run with both preCICE v2 and v3. The code works but was not extensively tested yet (mainly on the oscillator tutorial). However, this approach makes the code much less readable as a lot of if-else statements are included.

Maybe it makes more sense to make a clear cut in version compatibility: FMI runner v1.0.0 is only compatible with preCICE v3, while users interested in coupling to preCICE v2 can still use FMI runner v0.1.0

@uekerman Probably this was your intention all along and I misunderstood

@uekerman
Copy link
Member Author

Yes, it's not necessary that one version supports both v2 and v3. Let's only take v3 and eventually release v0.2.0 (no breaking changes from the perspective of the runner).

@uekerman
Copy link
Member Author

closed by #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeonardWilleke LeonardWilleke

Labels
None yet
Projects
preCICE version 3 overview
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uekerman @LeonardWilleke