Pushdown cast to source local

[yingsu00]

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

• Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• Adequate tests were added if applicable.
• CI passed.
• If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... 
* ... 

Hive Connector Changes
* ... 
* ... 

If release note is NOT required, use:

== NO RELEASE NOTE ==

[sourcery-ai]

Reviewer's Guide

This PR introduces a new native execution session property to push down integer upcasts to the scan operator, wiring it through both the Java and C++ layers, updating connector interfaces and tests, and also tweaks build configuration defaults for spatial support.

ER diagram for session property metadata changes

erDiagram
    SESSION_PROPERTY {
        string name
        string description
        string type
        bool defaultValue
        string configKey
        string value
    }
    SESSION_PROPERTY ||--o| NATIVE_PUSHDOWN_INTEGER_UPCASTS_TO_SCAN : contains

Loading

Class diagram for new and updated session property handling

classDiagram
    class NativeWorkerSessionPropertyProvider {
        +NATIVE_PUSHDOWN_INTEGER_UPCASTS_TO_SCAN : String
        ...
    }
    class SessionProperties {
        +kPushdownIntegerUpcastsToScan : const char*
        +addSessionProperty(...)
        ...
    }
    NativeWorkerSessionPropertyProvider --> SessionProperties : uses

Loading

File-Level Changes

Change	Details	Files
Add new native session property in Java layer	Define NATIVE_PUSHDOWN_INTEGER_UPCASTS_TO_SCAN constant Register booleanProperty in NativeWorkerSessionPropertyProvider	presto-main-base/src/main/java/com/facebook/presto/sessionpropertyproviders/NativeWorkerSessionPropertyProvider.java
Register session property in native C++ config	Add kPushdownIntegerUpcastsToScan constant in SessionProperties.h Invoke addSessionProperty for the new flag in SessionProperties.cpp	presto-native-execution/presto_cpp/main/SessionProperties.h presto-native-execution/presto_cpp/main/SessionProperties.cpp
Extend connector API to accept pushdown flag	Add pushdownCasts parameter to SystemConnector::read override	presto-native-execution/presto_cpp/main/connectors/SystemConnector.h
Update unit tests for new session property	Add expected mapping in SessionPropertiesTest Verify pushdownIntegerUpcastsToScan in QueryContextManagerTest	presto-native-execution/presto_cpp/main/tests/SessionPropertiesTest.cpp presto-native-execution/presto_cpp/main/tests/QueryContextManagerTest.cpp
Adjust build configuration defaults for spatial support	Disable spatial support by default in CMakeLists.txt Add status messages for CMake flags Comment out git submodule commands in Makefile	presto-native-execution/CMakeLists.txt presto-native-execution/Makefile
Clarify comment in PartitionAndSerialize operator	Update comment to reference outputWithoutUpcasts	presto-native-execution/presto_cpp/main/operators/PartitionAndSerialize.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[aditi-pandit]

This change should be reverted.

[aditi-pandit]

Remove these debug messages.

[aditi-pandit]

Same here. This is switching off SPATIAL needed for Bolt.

[aditi-pandit]

Remove these debug messages.

[aditi-pandit]

Remove these changes.

[steveburnett]

Please include documentation for the new session property, likely in https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/presto_cpp/properties-session.rst.