DynamicDialog onClose not called

[datbth]

Describe the bug

After using dialogRef.value.close() once, closing the Dynamic Dialog using header close button or escape key no longer triggers the onClose() callback.

Pull Request Link

No response

Reason for not contributing a PR

• Lack of time
• Unsure how to implement the fix/feature
• Difficulty understanding the codebase
• Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/primevue-4-vite-issue-template-aelagy3a?file=src%2FMyDialog.vue

Environment

as in stackblitz

Vue version

3.4.31

PrimeVue version

4.2.5

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

1. Click Button to open dialog
2. Click close icon in dialog header -> new console log showing that onClose() is called
3. Click Button to open dialog again
4. Click Close button in the dialog -> new console log showing that onClose() is called
5. Click Button to open dialog again
6. Click close icon in dialog header -> no new console log showing that onClose() is *not called

Expected behavior

Step 6: Click Close button in the dialog -> new console log showing that onClose() is called

[datbth]

I notice that

• This does not happen with primevue 4.0.0.rc3 (default version of the stackblitz template)
• In step 6, onDialogHide does not call onClose because this.currentInstance is present
  • Looks like this is because onDialogAfterHide is never called

[kerimcharfi]

+1