what does nexus build --deployment heroku do?

[chrisdrackett]

at first I thought since I'm deploying to Heroku I should have this be my build script, but looking at the logs it looks like this builds to a new Heroku instance?

[Weakky]

Hey @chrisdrackett,

The --deployment flag just helps you getting your codebase in a state that works with heroku. Right now, it's really just validation, you don't have to use it if it gets in your way for stupid reasons. If it does though, feel free to report issues so that we can enhance it!

Here are the validation that it does:

• Make sure you have a package.json
• Make sure your package.json has an engines property (required by heroku at the time we wrote that code)
• Make sure that the node version used in engines is the same as the one you use locally
• Make sure you have a build script that contains nexus build -d heroku
• Make sure you have a start script
• Make sure your start script actually start your nexus server

You can also check out the validation code here: https://github.com/graphql-nexus/nexus-future/blob/d722a8e611b50aa377b16ebea4919f2d740ab594/src/lib/build/deploy-target.ts#L138-L212

[chrisdrackett]

cool, I think what threw me a bit off (before I inspected the code) was this:

https://github.com/graphql-nexus/nexus/blob/d722a8e611b50aa377b16ebea4919f2d740ab594/src/lib/build/deploy-target.ts#L220

when I first saw this when inspecting the build log on Heroku I got confused that the build was creating and starting up a new Heroku server from inside our current server. This obviously isn't the case, but made me question what was going on :)