Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change check for logical histogram bins to throw an error if the user enters bins for a logical variable #92

Open
MeganFantes opened this issue Aug 12, 2019 · 1 comment
Assignees

Comments

@MeganFantes
Copy link
Contributor

The user should not enter a list of bins for a logical variable, the statistic will determine the bins for them based on the value of "impute". Change the "logical" condition in errorCheckBinVariableType to throw an error if there are any bins, the error should say: "Do not enter bins for a logical variable".

@MeganFantes MeganFantes self-assigned this Aug 12, 2019
@MeganFantes
Copy link
Contributor Author

Instead, changed determineBins() flow to check if the variable is logical before checking if bins have been entered. If the variable type is logical, then the bins will be set correctly by the statistic regardless of if the user entered bins or not (the user's bins will be ignored if they were entered)

MeganFantes added a commit that referenced this issue Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants