Skip to content

docs: In the plot_feature_importance example, rename the features after preprocessing #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sylvaincom opened this issue Mar 12, 2025 · 5 comments
Open

docs: In the plot_feature_importance example, rename the features after preprocessing #1421

sylvaincom opened this issue Mar 12, 2025 · 5 comments
Labels
documentation Improvements or additions to documentation fix-before-hackathon *Very* nice to have for upcoming skore challenges ("hackathons") good first issue Good for newcomers

Comments

@sylvaincom
Copy link
Contributor

sylvaincom commented Mar 12, 2025 •
edited
Loading

Which part of the documentation needs improvement?

plot_feature_importance example

Describe the problem found in the documentation

The feature names after complex feature engineering is not easily understandle. It would be nice to rename the features.

Currently (v0.8.2), we have:

Suggested improvement

  1. All the kmeans__* should be renamed into geospatial__* to make it clearer. Indeed the K-Means is applied only to the 2 geospatial features.
  2. All the remainder__* prefixes can be deleted as they are not necessary.

Additional context

I am open to suggestions
@sylvaincom sylvaincom added documentation Improvements or additions to documentation needs-triage This has been recently submitted and needs attention labels Mar 12, 2025
@sylvaincom sylvaincom added this to the spare week 0.8-0.9 milestone Mar 12, 2025
@sylvaincom sylvaincom self-assigned this Mar 12, 2025
@MarieSacksick MarieSacksick removed the needs-triage This has been recently submitted and needs attention label Mar 13, 2025
@MarieSacksick MarieSacksick removed this from the spare week 0.8-0.9 milestone Mar 26, 2025
@sylvaincom sylvaincom removed their assignment Apr 7, 2025
@auguste-probabl
Copy link
Contributor

auguste-probabl commented Apr 14, 2025 •
edited
Loading

@sylvaincom what names would you like?

@auguste-probabl auguste-probabl added the good first issue Good for newcomers label Apr 14, 2025
@sylvaincom
Copy link
Contributor Author

sylvaincom commented Apr 14, 2025 •
edited
Loading

I'd change all the "kmeans" to "geospatial" as suggested by @ogrisel. I'll add more information in the parent issue soon.

@sylvaincom
Copy link
Contributor Author

I just updated the parent issue, let me know if you have further suggestions

@Muhammad-Rebaal
Copy link
Contributor

Muhammad-Rebaal commented Apr 17, 2025 •
edited
Loading

Hi @sylvaincom , @auguste-probabl !
Could you please assign this issue to me ? I'd like to work on it .
Thank you!

@sylvaincom
Copy link
Contributor Author

Good luck @Muhammad-Rebaal, let us know if you need anything!

@sylvaincom sylvaincom added this to the spare week 0.9-0.10 milestone Apr 17, 2025
@sylvaincom sylvaincom added the fix-before-hackathon *Very* nice to have for upcoming skore challenges ("hackathons") label Apr 17, 2025
@sylvaincom sylvaincom removed this from the spare week 0.9-0.10 milestone Apr 17, 2025
@Muhammad-Rebaal Muhammad-Rebaal mentioned this issue Apr 18, 2025
Closed
@Muhammad-Rebaal Muhammad-Rebaal mentioned this issue May 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation fix-before-hackathon *Very* nice to have for upcoming skore challenges ("hackathons") good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
4 participants
@sylvaincom @MarieSacksick @Muhammad-Rebaal @auguste-probabl