perf: Make writing of ClojureCat ensembles more memory efficient #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zane
approved these changes
Jan 30, 2024
Contributor
zane
left a comment
zane
left a comment
There was a problem hiding this comment.
Combining the slurp with the EDN reading will further reduce memory usage.
Contributor
Author
|
Update: after chatting about this with Zane, we decided that we should use iql.query's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This uses
(prn)to print a ClojureCat ensemble and re-directs the output indvc.yamlto a file.Why do we want this?
Solves previous memory issues when running the dvc pipeline, e.g. with large CES models.
Why is this a draft?
This is a draft because resulting ensemble for CES is too large to be loaded into iql.query:
Unless, there is an obvious fix to the above, I guess we still merge?
@zane comments welcome.