Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revising algorithm for computing joint pdf #65

Open
fsaad opened this issue Oct 23, 2015 · 1 comment
Open

Revising algorithm for computing joint pdf #65

fsaad opened this issue Oct 23, 2015 · 1 comment
Milestone

Comments

@fsaad
Copy link
Collaborator

fsaad commented Oct 23, 2015

Currently predictive_probability is computed by invoking the chain rule on the legacy simple_predictive_probability. @axch suggests an alternative implementation

On second thought, crosscat should have a better algorithm for doing this:

  • Group the query columns by view
  • For each view that appears
  • Compute the cluster logps the way simple_predictive_probability does
  • For each cluster
    • Compute the sum of the component_model.calc_element_predictive_logp_constrained across relevant component models and add it to the cluster logp
  • Return the logsumexp of all the above.

In other words, retain the structure of simple_predictive_probability_unobserved (mutatis mutandis for observed) but expand it to handle multiple columns.

The reason this should be OK is independence of columns given cluster assignments.

The present implementation can be retained as a test, possibly at the Bayeslite level: the logpdf_joint of any metamodel should respect the chain rule exactly as computed here.

@fsaad
Copy link
Collaborator Author

fsaad commented Oct 23, 2015

Code referred to as "here": 950787f#diff-1c75fbbdfb035344508f37d7dce685b5R74

@raxraxraxraxrax raxraxraxraxrax added this to the analysis milestone Dec 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants