Skip to content

Commit 5cc7d75

Browse files
committed
Merge pull request #41 from ithielnor/master
Fix popover hiding, remove obsolete BS workaround
2 parents 223758c + 5c3b810 commit 5cc7d75

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

Build/CommonAssemblyInfo.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,5 @@
1515
//
1616
// You can specify all the values or you can default the Revision and Build Numbers
1717
// by using the '*' as shown below:
18-
[assembly: AssemblyVersion("1.0.84.1")]
19-
[assembly: AssemblyFileVersion("1.0.84.1")]
18+
[assembly: AssemblyVersion("1.0.84.3")]
19+
[assembly: AssemblyFileVersion("1.0.84.3")]

Griddly/Scripts/griddly.js

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -602,7 +602,7 @@
602602
// TODO: figure out how to have griddly in modal and still use body container. as it is, something about the modal
603603
// blocks inputs in popovers from getting focus. so as a fallback I put it back in the bouding container,
604604
// which will work but means it will get cut off if griddly is scrollable
605-
container: el, // this.$element.parents(".modal").length ? null : "body",
605+
container: null, // this.$element.parents(".modal").length ? null : "body",
606606
template: '<div class="popover griddly-filter-popover"><div class="arrow"></div><h3 class="popover-title"></h3><div class="popover-content"></div></div>',
607607
content: function ()
608608
{
@@ -1211,17 +1211,17 @@
12111211
$("[data-role=griddly]").griddly();
12121212
$(document).on("click", "[data-role=griddly-button]", GriddlyButton.handleClick);
12131213

1214-
// patch stupid bootstrap js so it doesn't .empty() our inline filter dropdowns
1215-
// remove once bs fixes: https://github.com/twbs/bootstrap/pull/14244
1216-
var setContent = $.fn.popover.Constructor.prototype.setContent;
1214+
// patch bootstrap js so it doesn't .empty() our inline filter dropdowns
1215+
// include if using bootstrap < 3.3.0
1216+
//var setContent = $.fn.popover.Constructor.prototype.setContent;
12171217

1218-
$.fn.popover.Constructor.prototype.setContent = function ()
1219-
{
1220-
var $tip = this.tip();
1218+
//$.fn.popover.Constructor.prototype.setContent = function ()
1219+
//{
1220+
// var $tip = this.tip();
12211221

1222-
$tip.find('.popover-content').children().detach();
1222+
// $tip.find('.popover-content').children().detach();
12231223

1224-
setContent.call(this);
1225-
};
1224+
// setContent.call(this);
1225+
//};
12261226
});
12271227
}(window.jQuery);

0 commit comments

Comments
 (0)