Skip to content

Commit d68ca13

Browse files
committed
Performance dehancement to support other libraries
#79
1 parent 742386b commit d68ca13

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

Griddly/Scripts/griddly.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1192,7 +1192,9 @@
11921192

11931193
var html = $(data);
11941194

1195-
this.$element.find("tbody.data").replaceWith(html.filter("tbody"));
1195+
// replaceWith is more performant, but using inner html allows us to maintain the tbody element which is potentially important for some other libraries
1196+
// https://github.com/programcsharp/griddly/issues/79
1197+
this.$element.find("tbody.data").html(html.filter("tbody").html());
11961198

11971199
var tfoot = this.$element.find("tfoot");
11981200

0 commit comments

Comments
 (0)