Skip to content

Commit ff4b13d

Browse files
authored
Merge pull request #133 from NLilley/adelas-changes
Include more BS5 tweaks for Griddly filters.
2 parents b953242 + f736781 commit ff4b13d

File tree

2 files changed

+14
-5
lines changed

2 files changed

+14
-5
lines changed

Build/CommonAssemblyInfo.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
// Minor Version
1313
// Build Number
1414
// Revision
15-
[assembly: AssemblyVersion("3.8.3")]
16-
[assembly: AssemblyFileVersion("3.8.3")]
15+
[assembly: AssemblyVersion("3.8.4")]
16+
[assembly: AssemblyFileVersion("3.8.4")]
1717
// Uncomment the informational version to create a pre-release package
18-
//[assembly: AssemblyInformationalVersion("3.8.1-rc2")]
18+
//[assembly: AssemblyInformationalVersion("3.8.4-rc2")]

Griddly/Views/Shared/Griddly/GriddlyFilters.cshtml

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,16 @@ else
4040
else
4141
{
4242
if (!css.Is(CssFramework.Bootstrap3)) { <h4 class="modal-title">Filter</h4> }
43-
<button type="button" class="close" data-dismiss="modal" aria-label="Close"><span aria-hidden="true">&times;</span></button>
43+
44+
if (css.Is(CssFramework.Bootstrap5))
45+
{
46+
<button type="button" class="griddly-modal-close close btn-close" data-bs-dismiss="modal" aria-label="Close"></button>
47+
}
48+
else
49+
{
50+
<button type="button" class="griddly-modal-close close" data-dismiss="modal" aria-label="Close"><span aria-hidden="true">&times;</span></button>
51+
}
52+
4453
if (css.Is(CssFramework.Bootstrap3)) { <h4 class="modal-title">Filter</h4> }
4554
}
4655
</div>
@@ -75,7 +84,7 @@ else
7584
}
7685
</div>
7786

78-
<button type="button" class="@(css.Is(CssFramework.Bootstrap4, CssFramework.Bootstrap5) ? "btn btn-link" : css.ButtonDefault) griddly-filter-cancel" data-dismiss="modal">Cancel</button>
87+
<button type="button" class="@(css.Is(CssFramework.Bootstrap4, CssFramework.Bootstrap5) ? "btn btn-link" : css.ButtonDefault) griddly-filter-cancel" data-dismiss="modal" data-bs-dismiss="modal">Cancel</button>
7988

8089
<button type="submit" class="@css.ButtonDefault">Search</button>
8190
}

0 commit comments

Comments
 (0)