No basic string in tests either (#159)

lrvideckis · web-flow · web-flow · commit 3dee57bedfda · 2025-08-14T10:27:46.000-06:00
* add grep for it * don't check comments for it * nits * revert * [auto-verifier] verify commit 0a42f02 * revert back to vector * remove double example inits --------- Co-authored-by: GitHub <noreply@github.com>
diff --git a/.verify-helper/timestamps.remote.json b/.verify-helper/timestamps.remote.json
@@ -132,9 +132,6 @@
 "tests/library_checker_aizu_tests/trees/edge_cd_count_paths_per_length.test.cpp": "2025-08-06 13:48:07 -0600",
 "tests/library_checker_aizu_tests/trees/edge_cd_reroot_dp.test.cpp": "2025-04-27 21:47:37 -0600",
 "tests/library_checker_aizu_tests/trees/kth_path_ladder.test.cpp": "2025-08-06 12:42:13 -0600",
-"tests/library_checker_aizu_tests/trees/kth_path_linear.test.cpp": "2025-08-06 12:42:13 -0600",
 "tests/library_checker_aizu_tests/trees/kth_path_tree_lift.test.cpp": "2025-08-06 12:42:13 -0600",
-"tests/library_checker_aizu_tests/trees/lca_all_methods_aizu.test.cpp": "2025-08-06 12:42:13 -0600",
-"tests/library_checker_aizu_tests/trees/lca_all_methods_lib_checker.test.cpp": "2025-08-06 12:42:13 -0600",
 "tests/library_checker_aizu_tests/trees/subtree_isomorphism.test.cpp": "2025-08-06 12:42:13 -0600"
 }
diff --git a/library/graphs/dijkstra.hpp b/library/graphs/dijkstra.hpp
@@ -1,9 +1,5 @@
 #pragma once
 //! @code
-//!   {
-//!     vector<vector<pair<int, ll>>> adj(n);
-//!     auto d = dijkstra(adj, source);
-//!   }
 //!   vector<basic_string<array<int, 2>>> adj(n);
 //!   auto d = dijkstra(adj, source);
 //! @endcode
diff --git a/library/graphs/hopcroft_karp.hpp b/library/graphs/hopcroft_karp.hpp
@@ -1,14 +1,9 @@
 #pragma once
 //! https://github.com/foreverbell/acm-icpc-cheat-sheet/blob/master/src/graph-algorithm/hopcroft-karp.cpp
 //! @code
-//!   {
-//!     vector<vi> adj(lsz);
-//!     auto [matching_size, to_r, to_l,
-//!       mvc_l, mvc_r] = hopcroft_karp(adj, rsz);
-//!   }
 //!   vector<basic_string<int>> adj(lsz);
 //!   adj[l] += r; // add edge l <-> r
-//!                        // 0<=l<lsz; 0<=r<rsz
+//!                // 0<=l<lsz; 0<=r<rsz
 //!   auto [matching_size, to_r, to_l,
 //!     mvc_l, mvc_r] = hopcroft_karp(adj, rsz);
 //! @endcode
diff --git a/library/graphs/scc.hpp b/library/graphs/scc.hpp
@@ -1,10 +1,6 @@
 #pragma once
 //! https://github.com/kth-competitive-programming/kactl/blob/main/content/graph/SCC.h
 //! @code
-//!   {
-//!     vector<vi> adj(n);
-//!     auto [num_sccs, scc_id] = sccs(adj);
-//!   }
 //!   vector<basic_string<int>> adj(n);
 //!   auto [num_sccs, scc_id] = sccs(adj);
 //! @endcode
diff --git a/library/graphs/uncommon/block_vertex_tree.hpp b/library/graphs/uncommon/block_vertex_tree.hpp
@@ -1,12 +1,6 @@
 #pragma once
 #include "cuts.hpp"
 //! @code
-//!   {
-//!     vector<vector<pii>> adj(n);
-//!     auto [num_bccs, bcc_id, is_cut] = cuts(adj, m);
-//!     auto bvt = block_vertex_tree(adj,
-//!       num_bccs, bcc_id);
-//!   }
 //!   vector<basic_string<array<int, 2>>> adj(n);
 //!   auto [num_bccs, bcc_id, is_cut] = cuts(adj, m);
 //!   auto bvt = block_vertex_tree(adj, num_bccs, bcc_id);
diff --git a/library/graphs/uncommon/bridge_tree.hpp b/library/graphs/uncommon/bridge_tree.hpp
@@ -1,11 +1,6 @@
 #pragma once
 #include "bridges.hpp"
 //! @code
-//!   {
-//!     vector<vector<pii>> adj(n);
-//!     auto [num_ccs, br_id, is_br] = bridges(adj, m);
-//!     auto bt = bridge_tree(adj, num_ccs, br_id, is_br);
-//!   }
 //!   vector<basic_string<array<int, 2>>> adj(n);
 //!   auto [num_ccs, br_id, is_br] = bridges(adj, m);
 //!   auto bt = bridge_tree(adj, num_ccs, br_id, is_br);
diff --git a/library/graphs/uncommon/bridges.hpp b/library/graphs/uncommon/bridges.hpp
@@ -1,10 +1,6 @@
 #pragma once
 //! https://cp-algorithms.com/graph/bridge-searching.html
 //! @code
-//!   {
-//!     vector<vector<pii>> adj(n);
-//!     auto [num_ccs, br_id, is_br] = bridges(adj, m);
-//!   }
 //!   vector<basic_string<array<int, 2>>> adj(n);
 //!   rep (i, 0, m) {
 //!     int u, v;
diff --git a/library/graphs/uncommon/complement_graph_ccs.hpp b/library/graphs/uncommon/complement_graph_ccs.hpp
@@ -1,9 +1,5 @@
 #pragma once
 //! @code
-//!   {
-//!     vector<vi> adj(n);
-//!     vi cc_id = get_complement_graph_ccs(adj);
-//!   }
 //!   vector<basic_string<int>> adj;
 //!   vi cc_id = get_complement_graph_ccs(adj);
 //! @endcode
diff --git a/library/graphs/uncommon/cuts.hpp b/library/graphs/uncommon/cuts.hpp
@@ -1,10 +1,6 @@
 #pragma once
 //! https://cp-algorithms.com/graph/cutpoints.html
 //! @code
-//!   {
-//!     vector<vector<pii>> adj(n);
-//!     auto [num_bccs, bcc_id, is_cut] = cuts(adj, m);
-//!   }
 //!   vector<basic_string<array<int, 2>>> adj(n);
 //!   rep (i, 0, m) {
 //!     int u, v;
diff --git a/library/trees/centroid_decomp.hpp b/library/trees/centroid_decomp.hpp
@@ -1,11 +1,5 @@
 #pragma once
 //! @code
-//!   {
-//!     vector<vi> adj(n);
-//!     centroid(adj, [&](const auto& adj,
-//!       int cent, int par_cent) {
-//!     });
-//!   }
 //!   vector<basic_string<int>> adj(n);
 //!   centroid(adj, [&](const auto& adj,
 //!     int cent, int par_cent) {});
diff --git a/library/trees/edge_cd.hpp b/library/trees/edge_cd.hpp
@@ -4,11 +4,6 @@
 //! https://codeforces.com/blog/entry/142176
 //! https://youtu.be/wDwaMo5xa-k
 //! @code
-//!   {
-//!     vector<vi> adj(n);
-//!     edge_cd(adj, [&](const auto& adj,
-//!       int cent, int m) {});
-//!   }
 //!   vector<basic_string<int>> adj(n);
 //!   edge_cd(adj, [&](const auto& adj, int cent, int m) {
 //!     // subtrees of [0, m) of adj[cent]: 1st edge-set
diff --git a/library/trees/lca_rmq.hpp b/library/trees/lca_rmq.hpp
@@ -3,10 +3,6 @@
 #include "../data_structures/rmq.hpp"
 //! https://github.com/kth-competitive-programming/kactl/blob/main/content/graph/LCA.h
 //! @code
-//!   {
-//!     vector<vi> adj(n);
-//!     LCA lca(adj);
-//!   }
 //!   vector<basic_string<int>> adj(n);
 //!   LCA lca(adj);
 //! @endcode
diff --git a/library/trees/linear_kth_par.hpp b/library/trees/linear_kth_par.hpp
@@ -1,10 +1,6 @@
 #pragma once
 //! https://codeforces.com/blog/entry/126580
 //! @code
-//!   {
-//!     vector<vi> adj(n);
-//!     linear_kth_par kp(adj);
-//!   }
 //!   vector<basic_string<int>> adj(n);
 //!   linear_kth_par kp(adj);
 //!   kp.kth_par(v, k); // k edges up from v
diff --git a/library/trees/linear_lca.hpp b/library/trees/linear_lca.hpp
@@ -1,10 +1,6 @@
 #pragma once
 //! https://codeforces.com/blog/entry/125371
 //! @code
-//!   {
-//!     vector<vi> adj(n);
-//!     linear_lca llca(adj);
-//!   }
 //!   vector<basic_string<int>> adj(n);
 //!   linear_lca llca(adj);
 //! @endcode
diff --git a/library/trees/tree_lift.hpp b/library/trees/tree_lift.hpp
@@ -1,13 +1,10 @@
 #pragma once
 //! https://github.com/ucf-programming-team/hackpack-cpp/blob/master/content/graphs/TreeLifting.h
 //! @code
-//!   {
-//!     vector<vi> adj(n);
-//!     tree_lift tree_l(adj);
-//!   }
 //!   vector<basic_string<int>> adj(n);
 //!   tree_lift tree_l(adj);
 //!   tree_l.kth_par(v, k); // k edges up from v
+//!   tree_l.kth_par(v, 1); // v's parent
 //! @endcode
 //! @time O(n + q log n)
 //! @space O(n)
diff --git a/library/trees/uncommon/subtree_isomorphism.hpp b/library/trees/uncommon/subtree_isomorphism.hpp
@@ -1,10 +1,5 @@
 #pragma once
 //! @code
-//!   {
-//!     vector<vi> adj(n);
-//!     auto [num_distinct_subtrees, iso_id] =
-//!       subtree_iso(adj);
-//!   }
 //!   vector<basic_string<int>> adj(n);
 //!   auto [num_distinct_subtrees, iso_id] =
 //!     subtree_iso(adj);
diff --git a/tests/library_checker_aizu_tests/graphs/bcc_callback_aizu_bcc.test.cpp b/tests/library_checker_aizu_tests/graphs/bcc_callback_aizu_bcc.test.cpp
@@ -6,13 +6,13 @@ int main() {
   cin.tie(0)->sync_with_stdio(0);
   int n, m;
   cin >> n >> m;
-  vector<basic_string<int>> adj(n);
-  for (int i = 0; i < n; i++) adj[i] += i;
+  vector<vector<int>> adj(n);
+  for (int i = 0; i < n; i++) adj[i].push_back(i);
   for (int i = 0; i < m; i++) {
     int u, v;
     cin >> u >> v;
-    adj[u] += v;
-    adj[v] += u;
+    adj[u].push_back(v);
+    adj[v].push_back(u);
   }
   vi cnt(n);
   bcc_callback(adj, [&](const vi& nodes) {
diff --git a/tests/library_checker_aizu_tests/graphs/bcc_callback_aizu_two_edge_cc.test.cpp b/tests/library_checker_aizu_tests/graphs/bcc_callback_aizu_two_edge_cc.test.cpp
@@ -6,13 +6,13 @@ int main() {
   cin.tie(0)->sync_with_stdio(0);
   int n, m;
   cin >> n >> m;
-  vector<basic_string<int>> adj(n);
-  for (int i = 0; i < n; i++) adj[i] += i;
+  vector<vi> adj(n);
+  for (int i = 0; i < n; i++) adj[i].push_back(i);
   for (int i = 0; i < m; i++) {
     int u, v;
     cin >> u >> v;
-    adj[u] += v;
-    adj[v] += u;
+    adj[u].push_back(v);
+    adj[v].push_back(u);
   }
   vector<pii> bridges;
   bcc_callback(adj, [&](const vi& nodes) {
diff --git a/tests/library_checker_aizu_tests/graphs/bcc_callback_lib_checker_bcc.test.cpp b/tests/library_checker_aizu_tests/graphs/bcc_callback_lib_checker_bcc.test.cpp
@@ -6,13 +6,13 @@ int main() {
   cin.tie(0)->sync_with_stdio(0);
   int n, m;
   cin >> n >> m;
-  vector<basic_string<int>> adj(n);
-  for (int i = 0; i < n; i++) adj[i] += i;
+  vector<vector<int>> adj(n);
+  for (int i = 0; i < n; i++) adj[i].push_back(i);
   for (int i = 0; i < m; i++) {
     int u, v;
     cin >> u >> v;
-    adj[u] += v;
-    adj[v] += u;
+    adj[u].push_back(v);
+    adj[v].push_back(u);
   }
   vector<bool> vis(n, 0);
   vector<vector<int>> all_bccs;
diff --git a/tests/library_checker_aizu_tests/graphs/bcc_callback_lib_checker_two_cc.test.cpp b/tests/library_checker_aizu_tests/graphs/bcc_callback_lib_checker_two_cc.test.cpp
@@ -7,12 +7,12 @@ int main() {
   cin.tie(0)->sync_with_stdio(0);
   int n, m;
   cin >> n >> m;
-  vector<basic_string<int>> adj(n);
+  vector<vi> adj(n);
   for (int i = 0; i < m; i++) {
     int u, v;
     cin >> u >> v;
-    adj[u] += v;
-    adj[v] += u;
+    adj[u].push_back(v);
+    adj[v].push_back(u);
   }
   UF uf(n);
   vector<bool> seen(n);
@@ -30,8 +30,8 @@ int main() {
     }
     for (int v : nodes) uf.join(v, nodes[0]);
   });
-  vector<basic_string<int>> two_edge_ccs(n);
-  rep(i, 0, n) two_edge_ccs[uf.find(i)] += i;
+  vector<vi> two_edge_ccs(n);
+  rep(i, 0, n) two_edge_ccs[uf.find(i)].push_back(i);
   int cnt_ccs = 0;
   rep(i, 0, n) cnt_ccs += (!empty(two_edge_ccs[i]));
   cout << cnt_ccs << '\n';
diff --git a/tests/library_checker_aizu_tests/trees/edge_cd_reroot_dp.test.cpp b/tests/library_checker_aizu_tests/trees/edge_cd_reroot_dp.test.cpp
@@ -14,7 +14,7 @@ int main() {
     cin >> a[i];
     res[i] = a[i];
   }
-  vector<basic_string<int>> adj(n);
+  vector<vi> adj(n);
   vector<mint> b(n - 1), c(n - 1);
   vector<pair<int, int>> par(n, {-1, -1});
   vector<vector<int>> base_adj(n);
@@ -47,7 +47,7 @@ int main() {
   };
   { edge_cd(base_adj, edge_cd_asserts); }
   edge_cd(adj,
-    [&](const vector<basic_string<int>>& cd_adj, int cent,
+    [&](const vector<vi>& cd_adj, int cent,
       int split) -> void {
       array<vector<array<mint, 3>>, 2> all_backwards;
       array<mint, 2> sum_forward = {0, 0};
diff --git a/tests/scripts/grep_clangformat_cppcheck.sh b/tests/scripts/grep_clangformat_cppcheck.sh
@@ -32,6 +32,9 @@ grep "ssize" --recursive ../library/ && exit 1
 echo "check vi instead of vector<int>"
 grep "vector<int>" --recursive ../library/**/*.hpp && exit 1
 
+echo "check no basic_string, excluding @code example inits"
+grep "[[:space:]]*//\!" --recursive --invert-match ../library/**/*.hpp library_checker_aizu_tests/**/*.test.cpp | grep "basic_string" && exit 1
+
 echo "check begin(arr) instead of arr.begin(), similarly for end, rbegin, rend, empty, size:"
 # TODO: remove this define filter if/when we move to -std=c++20
 grep --invert-match --fixed-strings "#define" --recursive ../library/ library_checker_aizu_tests/ |
