Skip to content

goroutine leak in Context.Run? #29

@ain-valtin

Description

@ain-valtin

It seems there is a goroutine leak in Context.Run: https://github.com/progrium/go-basher/blob/master/basher.go#L267 goroutine is launched which iterates over signals chan. But the chan is never closed, so the routine never exits... shouldn't there be something like

defer func() {
   signal.Stop(signals)
   close(signals)
}()

after signal.Notify(signals) call?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions