-
Notifications
You must be signed in to change notification settings - Fork 41
Open
Description
It seems there is a goroutine leak in Context.Run: https://github.com/progrium/go-basher/blob/master/basher.go#L267 goroutine is launched which iterates over signals chan. But the chan is never closed, so the routine never exits... shouldn't there be something like
defer func() {
signal.Stop(signals)
close(signals)
}()
after signal.Notify(signals)
call?
Metadata
Metadata
Assignees
Labels
No labels