Skip to content

Commit 925e59f

Browse files
authored
Merge pull request atom#23001 from DeeDeeG/raise-node-system-requirement
bootstrap: Update Node requirement to 10.12+ in system requirement checker
2 parents b3930b0 + f35e512 commit 925e59f

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

script/lib/verify-machine-requirements.js

+3-7
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,12 @@ module.exports = function(ci) {
1414
function verifyNode() {
1515
const fullVersion = process.versions.node;
1616
const majorVersion = fullVersion.split('.')[0];
17-
if (majorVersion >= 6) {
17+
const minorVersion = fullVersion.split('.')[1];
18+
if (majorVersion >= 11 || (majorVersion === '10' && minorVersion >= 12)) {
1819
console.log(`Node:\tv${fullVersion}`);
19-
} else if (majorVersion >= 4) {
20-
console.log(`Node:\tv${fullVersion}`);
21-
console.warn(
22-
'\tWarning: Building on Node below version 6 is deprecated. Please use Node 6.x+ to build Atom.'
23-
);
2420
} else {
2521
throw new Error(
26-
`node v4+ is required to build Atom. node v${fullVersion} is installed.`
22+
`node v10.12+ is required to build Atom. node v${fullVersion} is installed.`
2723
);
2824
}
2925
}

0 commit comments

Comments
 (0)