Skip to content

Commit 782f7ea

Browse files
authored
use standalone configuration/tests for devmode tests for CI (#309)
we're not faking the kueue webhook in the controller, so the devmode tests need to be changed to standalone (no kueue)
1 parent f3793e2 commit 782f7ea

File tree

4 files changed

+3
-7
lines changed

4 files changed

+3
-7
lines changed

.github/workflows/CI-devmode.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,6 @@ jobs:
4949
- name: Create and configure cluster
5050
run: ./hack/create-test-cluster.sh
5151

52-
- name: Deploy Kueue
53-
run: ./hack/deploy-kueue.sh
54-
5552
- name: Install CRDs
5653
run: |
5754
make install -e GIT_BRANCH=${{ env.GIT_BRANCH }} TAG=${{ env.GIT_BRANCH }}-${{ env.TAG }}

config/dev/config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ metadata:
55
data:
66
config.yaml: |
77
appwrapper:
8-
enableKueueIntegrations: true
8+
enableKueueIntegrations: false
99
controllerManager:
1010
health:
1111
bindAddress: "localhost:0"

docs/release_instructions.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@ will:
1616
+ create a [GitHub release](https://github.com/project-codeflare/appwrapper/releases) that contains the install.yaml
1717

1818
4. Update the kustomization.yaml files in MLBatch to refer to the new release:
19-
+ setup.k8s-v1.27/appwrapper/kustomization.yaml
20-
+ setup.k8s-v1.30/appwrapper/kustomization.yaml
19+
+ setup.k8s/appwrapper/kustomization.yaml
2120

2221
4. To workaround back level go versions in ODH, we also maintain a
2322
codeflare-releases branch. After making a release, merge main

hack/run-dev-mode-tests.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ run () {
3535
}
3636

3737
NAMESPACE=dev go run ./cmd/main.go &
38-
run $! go run github.com/onsi/ginkgo/v2/ginkgo -v -fail-fast --procs 1 -timeout 130m --label-filter=Kueue ./test/e2e
38+
run $! go run github.com/onsi/ginkgo/v2/ginkgo -v -fail-fast --procs 1 -timeout 130m --label-filter=Standalone ./test/e2e
3939

4040
RC=$?
4141
if [ ${RC} -eq 0 ]

0 commit comments

Comments
 (0)