fix: switching profiles in profileexplorer may result in Internal Error

starpit · starpit · commit 2b6a3fd128d6 · 2022-08-05T14:19:44.000-04:00
if we have yet to start a terminal pty job, the componentWillUnmount gets a null pointer exception
diff --git a/plugins/plugin-codeflare/src/components/RestartableTerminal.tsx b/plugins/plugin-codeflare/src/components/RestartableTerminal.tsx
@@ -100,9 +100,7 @@ export default class RestartableTerminal extends React.PureComponent<Props, Stat
 
   public componentWillUnmount() {
     this.mounted = false
-    if (this.state.job) {
-      this.state.job.abort()
-    }
+    this.state?.job?.abort()
   }
 
   public render() {

Original file line number	Diff line number	Diff line change
`@@ -100,9 +100,7 @@ export default class RestartableTerminal extends React.PureComponent<Props, Stat`
`100`	`100`
`101`	`101`	`public componentWillUnmount() {`
`102`	`102`	`this.mounted = false`
`103`		`- if (this.state.job) {`
`104`		`- this.state.job.abort()`
`105`		`- }`
	`103`	`+ this.state?.job?.abort()`
`106`	`104`	`}`
`107`	`105`
`108`	`106`	`public render() {`