Skip to content

Commit 6068e8c

Browse files
committed
feat: in hello.md, move profiles to the top
This PR also fixes a problem with the grid-template-columns of the profiles, by switching from a auto-fill to auto-fit. This makes sure that our `max-content` sizing gives less overflow.
1 parent eac0964 commit 6068e8c

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

plugins/plugin-codeflare/src/components/ProfileExplorer.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ export default class ProfileExplorer extends React.PureComponent<Props, State> {
157157

158158
{
159159
<GridItem>
160-
<Tile className="codeflare--tile codeflare--tile-new" title="New Profile" icon={<PlusIcon />} isStacked>
160+
<Tile className="codeflare--tile codeflare--tile-new" title="New Profile" icon={<PlusIcon />}>
161161
Customize a profile
162162
</Tile>
163163
</GridItem>

plugins/plugin-codeflare/web/scss/components/Hello/_index.scss

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@
2828
}
2929

3030
@include Split(3) {
31-
grid-template-rows: 2fr 1fr;
31+
grid-template-rows: 1fr 3.75fr;
3232
grid-template-columns: 1fr 2fr;
33-
grid-template-areas: "T1 T3" "T2 T3";
33+
grid-template-areas: "T1 T2" "T1 T3";
3434
}
3535
}
3636
}
@@ -140,7 +140,7 @@ $cell: 1.5em;
140140

141141
/** TODO move this somewhere else? */
142142
.codeflare--gallery-grid {
143-
grid-template-columns: repeat(auto-fill, minmax(10em, max-content));
143+
grid-template-columns: repeat(auto-fit, minmax(10em, max-content));
144144

145145
& > div {
146146
grid-column-start: unset;

0 commit comments

Comments
 (0)