Skip to content

Commit c398163

Browse files
committed
chore: pull guidebook store from @guidebooks/store npm
Rather than explicitly mirroring it here, use the pre-optimized published store. This also gives us version pegging.
1 parent 35647bc commit c398163

File tree

5 files changed

+26
-18
lines changed

5 files changed

+26
-18
lines changed

bin/codeflare

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -100,16 +100,15 @@ fi
100100
export KUI_ELECTRON_HOME="${KUI_ELECTRON_HOME-$NODE}"
101101

102102
if [ -z "$GUIDEBOOK_STORE" ]; then
103-
if [ -d "$HEADLESS"/../../store ]; then
103+
if [ -d "$HEADLESS"/../../node_modules/@guidebooks/store ]; then
104104
# development builds
105105
export GUIDEBOOK_STORE="$HEADLESS"/../../store
106106
elif [ -d "$HEADLESS"/store ]; then
107107
# docker builds
108108
export GUIDEBOOK_STORE="$HEADLESS"/store
109109
else
110-
# otherwise, we can't find a local mirror, so pull directly from
111-
# git (network transfers!)
112-
export GUIDEBOOK_STORE=git
110+
echo "Cannot find guidebook store"
111+
exit 1
113112
fi
114113
fi
115114

deploy/cli/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ ENV CODEFLARE_HEADLESS_HOME=/usr/local/CodeFlare
77

88
# TODO hard-coded arch
99
ADD dist/headless /usr/local/CodeFlare
10-
ADD store /usr/local/CodeFlare/store
10+
ADD node_modules/@guidebooks/store /usr/local/CodeFlare/store
1111
ADD bin/codeflare /usr/local/bin/codeflare
1212

1313
RUN apt update && apt -y install python3 python3-pip sudo curl \

deploy/log-aggregator/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ ENV CODEFLARE_HEADLESS_HOME=/usr/local/CodeFlare
77

88
# TODO hard-coded arch
99
ADD dist/headless /usr/local/CodeFlare
10-
ADD store /usr/local/CodeFlare/store
10+
ADD node_modules/@guidebooks/store /usr/local/CodeFlare/store
1111
ADD bin/codeflare /usr/local/bin/codeflare
1212
ADD deploy/log-aggregator/wait-for.sh /usr/local/bin/wait-for
1313
ADD deploy/log-aggregator/wait-for-and-cat.sh /usr/local/bin/wait-for-and-cat

package-lock.json

Lines changed: 11 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -18,33 +18,30 @@
1818
"pty:electron": "npm run pty:rebuild electron",
1919
"pty:nodejs": "npm run pty:rebuild node",
2020
"prepare": "cross-env husky install",
21-
"preprod": "npm run mirror",
2221
"build:docker:cli": "npm run build:docker1 && docker build -f deploy/cli/Dockerfile -t ghcr.io/project-codeflare/codeflare-cli .",
2322
"build:docker:logs": "npm run build:docker1 && docker build -f deploy/log-aggregator/Dockerfile -t ghcr.io/project-codeflare/codeflare-log-aggregator .",
2423
"build:docker1": "if [ ! -n \"$FAST\" ]; then npm run build:docker0; fi",
25-
"build:docker0": "npm run mirror && CLIENT_HOME=$PWD webpack-cli --mode=${MODE-production} --config node_modules/@kui-shell/webpack/headless-webpack.config.js",
24+
"build:docker0": "CLIENT_HOME=$PWD webpack-cli --mode=${MODE-production} --config node_modules/@kui-shell/webpack/headless-webpack.config.js",
2625
"docker:debug": "ENTRYPOINT=bash ./bin/codeflare -d",
27-
"build:electron:mac:amd64": "npm run preprod && KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare PLATFORM=mac ARCH=x64 kui-build-electron",
28-
"build:electron:mac:arm64": "npm run preprod && KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare PLATFORM=mac ARCH=arm64 kui-build-electron",
29-
"build:electron:osx:amd64": "npm run preprod && KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare npm run build:electron:mac:amd64",
30-
"build:electron:osx:arm64": "npm run preprod && KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare npm run build:electron:mac:arm64",
26+
"build:electron:mac:amd64": "KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare PLATFORM=mac ARCH=x64 kui-build-electron",
27+
"build:electron:mac:arm64": "KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare PLATFORM=mac ARCH=arm64 kui-build-electron",
28+
"build:electron:osx:amd64": "KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare npm run build:electron:mac:amd64",
29+
"build:electron:osx:arm64": "KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare npm run build:electron:mac:arm64",
3130
"build:electron:macOS:X64": "npm run build:electron:mac:amd64",
3231
"build:electron:macOS:ARM64": "npm run build:electron:mac:arm64",
33-
"build:electron:linux:amd64": "npm run preprod && KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare PLATFORM=linux ARCH=x64 kui-build-electron",
34-
"build:electron:linux:arm64": "npm run preprod && KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare PLATFORM=linux ARCH=arm64 kui-build-electron",
32+
"build:electron:linux:amd64": "KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare PLATFORM=linux ARCH=x64 kui-build-electron",
33+
"build:electron:linux:arm64": "KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare PLATFORM=linux ARCH=arm64 kui-build-electron",
3534
"build:electron:Linux:X64": "npm run build:electron:linux:amd64",
3635
"build:electron:Linux:ARM64": "npm run build:electron:linux:armd64",
37-
"build:electron:win32:amd64": "npm run preprod && cross-env KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare PLATFORM=win32 ARCH=x64 kui-build-electron",
36+
"build:electron:win32:amd64": "cross-env KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare PLATFORM=win32 ARCH=x64 kui-build-electron",
3837
"build:electron:Windows:X64": "npm run build:electron:win32:amd64",
39-
"build:electron:all": "npm run preprod && KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare kui-build-electron",
38+
"build:electron:all": "KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare kui-build-electron",
4039
"build": "npm run compile && webpack --mode production",
4140
"postinstall": "npm run compile",
4241
"format": "prettier --write '**/*.{scss,css,html,js,json,md,ts,tsx}'",
4342
"lint": "eslint . --ext '**/*.{js,ts,tsx}'",
4443
"open": "./bin/codeflare hello",
4544
"start": "WATCH_ARGS='-open' npm run watch",
46-
"mirror": "cross-env rm -rf tmp && cross-env git clone --depth=1 https://github.com/guidebooks/store.git $PWD/tmp/store && cross-env madwizard mirror $PWD/tmp/store/guidebooks $PWD/store && rm -rf tmp",
47-
"mirror-if-needed": "if [ ! -d ./store ]; then npm run mirror; fi",
4845
"test": "cross-env RUNNING_KUI_TEST=true playwright test --workers 1"
4946
},
5047
"keywords": [],
@@ -115,6 +112,7 @@
115112
"typescript": "4.7.4"
116113
},
117114
"dependencies": {
115+
"@guidebooks/store": "^0.0.1",
118116
"@kui-shell/client": "file:./plugins/plugin-client-default",
119117
"@kui-shell/core": "11.5.0-dev-20220807-191654",
120118
"@kui-shell/plugin-bash-like": "11.5.0-dev-20220807-191654",

0 commit comments

Comments
 (0)