Skip to content

Commit bf2f194

Browse files
committed
minor revise for cpumem client stage3
1 parent 8b80aec commit bf2f194

File tree

4 files changed

+37
-6
lines changed

4 files changed

+37
-6
lines changed

resource/cobalt/node.go

+1
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ func (m Manager) AddNode(ctx context.Context, nodename string, opts resourcetype
3333
resps, err := call(ctx, m.plugins, func(plugin plugins.Plugin) (*plugintypes.AddNodeResponse, error) {
3434
r := opts[plugin.Name()]
3535
if r == nil {
36+
logger.WithField("plugin", plugin.Name()).Warn(ctx, "empty plugin config")
3637
return &plugintypes.AddNodeResponse{}, nil
3738
}
3839
logger.WithField("plugin", plugin.Name()).WithField("node", nodename).Infof(ctx, "%v", litter.Sdump(r))

resource/plugins/cpumem/client/cpu.go

+35
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
package client
2+
3+
import (
4+
"fmt"
5+
"strings"
6+
7+
"github.com/projecteru2/core/resource/plugins/cpumem/types"
8+
"github.com/projecteru2/core/utils"
9+
)
10+
11+
// NewNUMAFromStr .
12+
func NewNUMAFromStr(numa []string) (types.NUMA, error) {
13+
r := types.NUMA{}
14+
for index, numaCPUList := range numa {
15+
nodeID := fmt.Sprintf("%d", index)
16+
for _, cpuID := range strings.Split(numaCPUList, ",") {
17+
r[cpuID] = nodeID
18+
}
19+
}
20+
return r, nil
21+
}
22+
23+
// NewNUMAMemoryFromStr .
24+
func NewNUMAMemoryFromStr(numaMemory []string) (types.NUMAMemory, error) {
25+
r := types.NUMAMemory{}
26+
for index, nodeMemory := range numaMemory {
27+
nodeID := fmt.Sprintf("%d", index)
28+
mem, err := utils.ParseRAMInHuman(nodeMemory)
29+
if err != nil {
30+
return r, err
31+
}
32+
r[nodeID] = mem
33+
}
34+
return r, nil
35+
}

resource/plugins/cpumem/types/node.go

+1
Original file line numberDiff line numberDiff line change
@@ -215,6 +215,7 @@ func (n *NodeResourceRequest) Parse(config coretypes.Config, rawParams resourcet
215215
}
216216

217217
for nodeID, nodeMemory := range rawParams.RawParams("numa-memory") {
218+
// stupid golang covert int64 to float64 when using json.unmarshal
218219
n.NUMAMemory[nodeID] = int64(nodeMemory.(float64))
219220
}
220221
return nil

rpc/transform.go

-6
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import (
1212
pb "github.com/projecteru2/core/rpc/gen"
1313
"github.com/projecteru2/core/types"
1414
"github.com/projecteru2/core/utils"
15-
"github.com/sanity-io/litter"
1615

1716
"golang.org/x/net/context"
1817
)
@@ -540,17 +539,12 @@ func toCoreRemoveImageOptions(opts *pb.RemoveImageOptions) *types.ImageOptions {
540539
func toCoreResources(resources map[string][]byte) resourcetypes.Resources {
541540
r := resourcetypes.Resources{}
542541
for k, v := range resources {
543-
fmt.Println("==============")
544-
fmt.Println(k, string(v))
545-
fmt.Println("==============")
546542
rp := resourcetypes.RawParams{}
547543
if err := json.Unmarshal(v, &rp); err != nil {
548544
log.WithFunc("toCoreResources").Errorf(nil, err, "%v", string(v)) // nolint
549545
continue
550546
}
551547
r[k] = rp
552-
litter.Dump(rp)
553-
fmt.Println("==============")
554548
}
555549
return r
556550
}

0 commit comments

Comments
 (0)