Skip to content

Commit b0ee1a1

Browse files
committed
Apply review suggestions
1 parent 2ec0a63 commit b0ee1a1

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

fluent.runtime/fluent/runtime/resolver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,7 @@ def __call__(self, env: ResolverEnvironment) -> Any:
398398

399399
class NamedArgument(FTL.NamedArgument, BaseResolver):
400400
name: Identifier
401-
value: Union[NumberLiteral, StringLiteral]
401+
value: Union[NumberLiteral, StringLiteral, VariableReference]
402402

403403

404404
InlineExpression = Union[

fluent.runtime/tests/format/test_parameterized_terms.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,13 @@ def test_variable_named_arg(self, bundle):
7373
assert val == "a thing"
7474
assert errs == []
7575

76+
def test_missing_variable_named_arg(self, bundle):
77+
val, errs = bundle.format_pattern(
78+
bundle.get_message("thing-variable-arg").value, {}
79+
)
80+
assert val == "the thing"
81+
assert errs == [FluentReferenceError('Unknown external: art')]
82+
7683
def test_no_implicit_access_to_external_args(self, bundle):
7784
# The '-thing' term should not get passed article="indefinite"
7885
val, errs = bundle.format_pattern(

0 commit comments

Comments
 (0)