Skip to content

Commit cd5ffce

Browse files
committed
native histogram spec: Remove obsolete TODOs about PromQL
Signed-off-by: beorn7 <[email protected]>
1 parent e90c215 commit cd5ffce

File tree

1 file changed

+7
-16
lines changed

1 file changed

+7
-16
lines changed

content/docs/specs/native_histograms.md

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1607,11 +1607,6 @@ the latter, refer to the PromQL documentation about
16071607
and
16081608
[functions](https://prometheus.io/docs/prometheus/latest/querying/functions/).
16091609

1610-
TODO: The Prometheus PromQL implementation is currently lagging behind what's
1611-
described in this section. This is not called out separately further down for
1612-
all cases. See [tracking
1613-
issue](https://github.com/prometheus/prometheus/issues/13934) for details.
1614-
16151610
### Annotations
16161611

16171612
The introduction of native histograms creates certain situations where a PromQL
@@ -1903,7 +1898,6 @@ histogram to gauge histogram and vice versa does not count as a change for
19031898
histograms, but the function still works with gauge histograms, applying
19041899
explicit counter reset detection in this case. Furthermore, a change from
19051900
counter histogram to gauge histogram and vice versa is counted as a reset.
1906-
(TODO: Not implemented yet.)
19071901

19081902
The `histogram_quantile()` function has a very special role as it is the only
19091903
function that treats a specific “magic” label specially, namely the `le` label
@@ -1998,8 +1992,7 @@ definition of the schema of the histogram.
19981992

19991993
The following functions do not interact directly with sample values and
20001994
therefore work with native histogram samples in the same way as they work with
2001-
float samples: (TODO: Still need to verify that this is true for all of the
2002-
functions below. Need to update the documentation for some of them.)
1995+
float samples:
20031996

20041997
- `absent()`
20051998
- `absent_over_time()`
@@ -2014,14 +2007,12 @@ functions below. Need to update the documentation for some of them.)
20142007
- `timestamp()`
20152008

20162009
All remaining functions not mentioned in this section do _not_ work with native
2017-
histograms. Histogram elements in the input vector are silently ignored. (TODO:
2018-
Make sure this is the case, rather than treating histogram samples as floats
2019-
with value 0.) For `deriv()`, `double_exponential_smoothing()`,
2020-
`predict_linear()`, and all the `<aggregation>_over_time()` functions not
2021-
mentioned before, native histogram samples are removed from the input range
2022-
vector. In case any series contains a mix of float samples and histogram
2023-
samples within the range, the removal of histograms is flagged by an info-level
2024-
annotation.
2010+
histograms. Histogram elements in the input vector are silently ignored. For
2011+
`deriv()`, `double_exponential_smoothing()`, `predict_linear()`, and all the
2012+
`<aggregation>_over_time()` functions not mentioned before, native histogram
2013+
samples are removed from the input range vector. In case any series contains a
2014+
mix of float samples and histogram samples within the range, the removal of
2015+
histograms is flagged by an info-level annotation.
20252016

20262017
### Recording rules
20272018

0 commit comments

Comments
 (0)