Merge pull request #84 from arnedesmedt/feature/php8.4-remove-deprecations

prolic · web-flow · commit 8f0a00736d65 · 2025-01-21T20:09:07.000-03:00
Remove deprecations for php8.4
diff --git a/src/Event/ActionEventEmitter.php b/src/Event/ActionEventEmitter.php
@@ -26,7 +26,7 @@ interface ActionEventEmitter
      *
      * @return ActionEvent that can be triggered by the ActionEventEmitter
      */
-    public function getNewActionEvent(string $name = null, $target = null, $params = null): ActionEvent;
+    public function getNewActionEvent(?string $name = null, $target = null, $params = null): ActionEvent;
 
     public function dispatch(ActionEvent $event): void;
 
diff --git a/src/Event/ProophActionEventEmitter.php b/src/Event/ProophActionEventEmitter.php
@@ -42,7 +42,7 @@ public function __construct(array $availableEventNames = [])
      *
      * @return ActionEvent that can be triggered by the ActionEventEmitter
      */
-    public function getNewActionEvent(string $name = null, $target = null, $params = null): ActionEvent
+    public function getNewActionEvent(?string $name = null, $target = null, $params = null): ActionEvent
     {
         if ($name === null) {
             $name = 'action_event';

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ interface ActionEventEmitter`
`26`	`26`	`*`
`27`	`27`	`* @return ActionEvent that can be triggered by the ActionEventEmitter`
`28`	`28`	`*/`
`29`		`- public function getNewActionEvent(string $name = null, $target = null, $params = null): ActionEvent;`
	`29`	`+ public function getNewActionEvent(?string $name = null, $target = null, $params = null): ActionEvent;`
`30`	`30`
`31`	`31`	`public function dispatch(ActionEvent $event): void;`
`32`	`32`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ public function __construct(array $availableEventNames = [])`
`42`	`42`	`*`
`43`	`43`	`* @return ActionEvent that can be triggered by the ActionEventEmitter`
`44`	`44`	`*/`
`45`		`- public function getNewActionEvent(string $name = null, $target = null, $params = null): ActionEvent`
	`45`	`+ public function getNewActionEvent(?string $name = null, $target = null, $params = null): ActionEvent`
`46`	`46`	`{`
`47`	`47`	`if ($name === null) {`
`48`	`48`	`$name = 'action_event';`