Skip to content

Bad values for launched/concluded when times are unknown #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PeterJCLaw opened this issue Dec 3, 2020 · 0 comments
Open

Bad values for launched/concluded when times are unknown #112

PeterJCLaw opened this issue Dec 3, 2020 · 0 comments

Comments

@PeterJCLaw
Copy link
Contributor

For experiments where the launched or concluded times are unknown, the web API exposes the string 'None' rather than a JSON null value. This makes parsing the data harder than necessary.

It seems that this is a result of the naive JSON preparation of the data done in

"launched": str(experiment_config.launched),
"concluded": str(experiment_config.concluded),

I think the fix is to either have these check for None before calling str or to push the datetime string conversion into the JSON encoder so that types are handled generically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant