Move connection timeout to constant

punkstar · punkstar · commit ea79096131a1 · 2016-09-16T11:55:17.000+01:00
diff --git a/src/Punkstar/Ssl/Reader.php b/src/Punkstar/Ssl/Reader.php
@@ -4,6 +4,7 @@
 
 class Reader
 {
+    const CONNECTION_TIMEOUT = 30;
 
     /**
      * @param $url
@@ -26,7 +27,7 @@ public function readFromUrl($url)
             )
         ));
 
-        $stream = @stream_socket_client("ssl://" . $urlHost . ":443", $errorNumber, $errorString, 30, STREAM_CLIENT_CONNECT, $streamContext);
+        $stream = @stream_socket_client("ssl://" . $urlHost . ":443", $errorNumber, $errorString, self::CONNECTION_TIMEOUT, STREAM_CLIENT_CONNECT, $streamContext);
 
         if ($stream) {
             $streamParams = stream_context_get_params($stream);

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@`
`4`	`4`
`5`	`5`	`class Reader`
`6`	`6`	`{`
	`7`	`+ const CONNECTION_TIMEOUT = 30;`
`7`	`8`
`8`	`9`	`/**`
`9`	`10`	`* @param $url`
`@@ -26,7 +27,7 @@ public function readFromUrl($url)`
`26`	`27`	`)`
`27`	`28`	`));`
`28`	`29`
`29`		`- $stream = @stream_socket_client("ssl://" . $urlHost . ":443", $errorNumber, $errorString, 30, STREAM_CLIENT_CONNECT, $streamContext);`
	`30`	`+ $stream = @stream_socket_client("ssl://" . $urlHost . ":443", $errorNumber, $errorString, self::CONNECTION_TIMEOUT, STREAM_CLIENT_CONNECT, $streamContext);`
`30`	`31`
`31`	`32`	`if ($stream) {`
`32`	`33`	`$streamParams = stream_context_get_params($stream);`