puppet-4.3 with this module get error

[wisre]

hi,i used this module with puppet-4.3,i got this error,please help me

Info: Using configured environment 'production'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Notice: /File[/opt/puppetlabs/puppet/cache/lib/facter]/ensure: created
Notice: /File[/opt/puppetlabs/puppet/cache/lib/facter/gluster_bricks.rb]/ensure: defined content as '{md5}4914f9caf2590f4fa50c343c5574c8c1'
Notice: /File[/opt/puppetlabs/puppet/cache/lib/facter/gluster_fsm.rb]/ensure: defined content as '{md5}5bd63ed45b9eff3e55b1d06a132083a8'
Notice: /File[/opt/puppetlabs/puppet/cache/lib/facter/gluster_fsuuid.rb]/ensure: defined content as '{md5}af47ec02c6ba770dcaad847929f7183d'
Notice: /File[/opt/puppetlabs/puppet/cache/lib/facter/gluster_host.rb]/ensure: defined content as '{md5}f524ca9164435096286d8e554e47aa1b'
Notice: /File[/opt/puppetlabs/puppet/cache/lib/facter/gluster_ports.rb]/ensure: defined content as '{md5}4d958b92adff3ed1850b0cf14812e451'
Notice: /File[/opt/puppetlabs/puppet/cache/lib/facter/gluster_property.rb]/ensure: defined content as '{md5}e88be8242b20a7bcbec7ae021aa877bb'
Notice: /File[/opt/puppetlabs/puppet/cache/lib/facter/gluster_uuid.rb]/ensure: defined content as '{md5}2e390c113c41b121caf574c7ad2feb9e'
Notice: /File[/opt/puppetlabs/puppet/cache/lib/facter/gluster_version.rb]/ensure: defined content as '{md5}80dc53f10f58e9cbf825f9bb3470fdae'
Notice: /File[/opt/puppetlabs/puppet/cache/lib/facter/gluster_vrrp.rb]/ensure: defined content as '{md5}5549dda98e03212992b495aa593686f9'
Notice: /File[/opt/puppetlabs/puppet/cache/lib/puppet]/ensure: created
Notice: /File[/opt/puppetlabs/puppet/cache/lib/puppet/parser]/ensure: created
Notice: /File[/opt/puppetlabs/puppet/cache/lib/puppet/parser/functions]/ensure: created
Notice: /File[/opt/puppetlabs/puppet/cache/lib/puppet/parser/functions/brick_layout_chained.rb]/ensure: defined content as '{md5}6821db734ba5cf11b8cc358217f47187'
Notice: /File[/opt/puppetlabs/puppet/cache/lib/puppet/parser/functions/brick_layout_simple.rb]/ensure: defined content as '{md5}a6b61871bef7ea6ea6e7e0de10212915'
Notice: /File[/opt/puppetlabs/puppet/cache/lib/puppet/parser/functions/brick_str_to_hash.rb]/ensure: defined content as '{md5}fcff5409d84312da693fdf736aa0bed8'
Notice: /File[/opt/puppetlabs/puppet/cache/lib/puppet/parser/functions/get_brickstacks.rb]/ensure: defined content as '{md5}a0fd24d8c6084dfdc0f449eca19b8f6c'
Notice: /File[/opt/puppetlabs/puppet/cache/lib/puppet/parser/functions/get_hostlist.rb]/ensure: defined content as '{md5}b87e7646ad8446e7e97e0351af4c628b'
Info: Loading facts
Error: Facter: error while resolving custom fact "gluster_property_groups_ready": no implicit conversion of nil into String
Info: Caching catalog for sysbackup.corp.xxx.com
Info: Applying configuration version '1451386563'
Notice: hello, world!
Notice: /Stage[main]/Helloworld/Notify[hello, world!]/message: defined 'message' as 'hello, world!'
Notice: hello gluster
Notice: /Stage[main]/Gluster/Notify[hello gluster]/message: defined 'message' as 'hello gluster'
Notice: Applied catalog in 0.04 seconds

my gluster module like this:

class gluster {
notify{"hello gluster":}

}

[purpleidea]

The error looks like it's here:

Error: Facter: error while resolving custom fact "gluster_property_groups_ready": no implicit conversion of nil into String

You'll have to track down what is causing that and patch it, which I'm happy to accept. This is probably due to something that changed in v3 puppet -> v4 puppet, although that's just a guess.

Unfortunately I'm busy with another project at the moment, so while I'm happy to review your patch, I can't write it for you.

[wisre]

thanks , i would like to have a try

[purpleidea]

On Tue, Dec 29, 2015 at 7:48 AM, wisre notifications@github.com wrote:

thanks , i would like to have a try

great to hear it!

[Vincent--]

This should be related to a nil value for "valid_setgroupdir" inside the gluster_property_groups_ready fact
setcode { (File.directory?(valid_setgroupdir) ? 'true':'false') }
see gluster_property.rb

What are the output of these facts on your system ?
facter puppet_vardirtmp
facter puppet_vardir

[wisre]

both are nil

[Vincent--]

Sorry, could you try with that ?
sudo facter -p puppet_vardir
sudo facter -p puppet_vardirtmp

Could you also include your puppet and facter version ?
sudo puppet --version
sudo facter --version

and your OS version ?
and the entire manifest you use ? :-)