-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gabor's Data PyFixest Wishlist #752
Comments
Hi @s3alfisc, I created a poc for context capture aka I think it would be good to have this in pyfixest, apart from the fact that we'd need it in the Gabor's DA book codebase – eg. statsmodels have this functionality. This is just a POC as I'm not familiar with the pyfixest codebase, but it worked for me in some case studies I tested. FYI @gbekes, we need this for logit and probit too as splines are used extensively there. |
Hi @adamvig96 , to make sure I understand the problem correctly - you need formulaic to parse a custom data transform (in this case a spline) and need to provide the extra context via the feols / fepois APIs? If yes I very much agree that this would be a very useful feature to have! If yes, I took a quick initial look at your code and I think it looks quite good already - I don't think there'd be much to add except maybe some tests (happy to help with that =) ). If you open a PR, we can get started with getting this into pyfixest =) |
Thanks! |
I will merge logit + probit tomorrow (I am encountering a strange bug that I currently cannot explain), will then continue with R2 for WLS. Then the prediction intervals, last HAC. |
We've just merged R2 for WLS (and within and adjusted R2 too)! PR here, thanks to @AronNemeth. I am also finalizing the prediction standard error PR , I should finish it by tomorrow evening. Then only HAC will be left =) |
... and we've merged the prediction errors PR. @adamvig96 @gbekes |
Hi, @s3alfisc, in chapter 17 of the book we would like to show the AMEs of a logit. In the documentation you gave an example using the marginaleffects package that I tried to replicate (in the "Quick reminder about probability models" part of the notebook) but the avg_slopes function simply gives back the original logit coefficients, not the AMEs, as if it was an OLS regression. Have you encountered anything similar? Or do you have any ideas that we chould try? On another note: in our conda environment we could only use marginaleffects==0.0.11 because of a dependency issue regarding numpy (numba needs numpy<1.27, that comes with pyfixest, while marginaleffects=0.1.0 needs numpy>2.0.0), maybe this causes the issue? |
Hi @DanielBarabas , this can indeed be the case! To create the docs, I am using marginaleffects 0.0.14:
But I am also running higher numpy and numba versions?
This is all under pyfixest 0.28.0 and the Which version of numba do you have installed? |
Thanks, I will check the numba bc that might be it (when i get to my laptop) |
I plan to tackle some of these over the holidays:
The text was updated successfully, but these errors were encountered: