DEV: Remove ignoring Ruff rule PGH004 (#3071)

PGH004 is use specific rule codes when using `noqa`.

Additionally fixes a bug discovered by this.

Author: j-t-1

make_release.py

@@ -138,7 +138,7 @@ def write_release_msg_file(
 
 def strip_header(md: str) -> str:
     """Remove the 'CHANGELOG' header."""
-    return md.lstrip("# CHANGELOG").lstrip()  # noqa
+    return md.removeprefix("# CHANGELOG").lstrip()
 
 
 def version_bump(git_tag: str) -> str:

pypdf/_encryption.py

@@ -781,7 +781,7 @@ class EncryptAlgorithm(tuple, Enum):  # type: ignore # noqa: SLOT001
 
 
 class EncryptionValues:
-    O: bytes  # noqa
+    O: bytes  # noqa: E741
     U: bytes
     OE: bytes
     UE: bytes

pypdf/constants.py

@@ -42,7 +42,7 @@ class EncryptionDictAttributes:
     """
 
     R = "/R"  # number, required; revision of the standard security handler
-    O = "/O"  # 32-byte string, required  # noqa
+    O = "/O"  # 32-byte string, required  # noqa: E741
     U = "/U"  # 32-byte string, required
     P = "/P"  # integer flag, required; permitted operations
     ENCRYPT_METADATA = "/EncryptMetadata"  # boolean flag, optional

pypdf/generic/_data_structures.py

@@ -735,7 +735,7 @@ def inc_parent_counter_outline(
         assert parent is not None, "mypy"
         parent = cast("TreeObject", parent.get_object())
         #  BooleanObject requires comparison with == not is
-        opn = parent.get("/%is_open%", True) == True  # noqa
+        opn = parent.get("/%is_open%", True) == True  # noqa: E712
         c = cast(int, parent.get("/Count", 0))
         if c < 0:
             c = abs(c)

pyproject.toml

@@ -162,7 +162,6 @@ ignore = [
     "N817",    # CamelCase `PagesAttributes` imported as acronym `PA`
     "PERF203", # `try`-`except` within a loop incurs performance overhead
     "PGH003",  # Use specific rule codes when ignoring type issues
-    "PGH004",  # Use specific rule codes when using `noqa`
     "PLC0206", # Extracting value from dictionary without calling `.items()`
     "PLR1714", # Consider merging multiple comparisons
     "PLW0602", # Using global for `CUSTOM_RTL_SPECIAL_CHARS` but no assignment is done

tests/scripts/test_make_release.py

@@ -1,4 +1,5 @@
 """Test the `make_release.py` script."""
+import sys
 from pathlib import Path
 from unittest import mock
 
@@ -15,6 +16,26 @@
 f851a532a5ec23b572d86bd7185b327a3fac6b58:::DEV: Bump codecov/codecov-action from 3 to 4 (#2430):::dependabot[bot]""".encode()  # noqa: E501
 
 COMMITS__VERSION_4_0_1 = DATA_PATH.joinpath("commits__version_4_0_1.json")
+VERSION_3_9_PLUS = sys.version_info[:2] >= (3, 9)
+
+
+@pytest.mark.skipif(not VERSION_3_9_PLUS, reason="Function uses method removeprefix added in Python 3.9")
+@pytest.mark.parametrize(
+    ("data", "expected"),
+    [
+        ("", ""),
+        ("# CHANGELOG", ""),
+        ("# CHANGELOG ", ""),
+        ("# CHANGELOG  ", ""),
+        ("## CHANGELOG", "## CHANGELOG"),
+        ("CHANGELOG", "CHANGELOG"),
+        ("# CHANGELOG #", "#"),
+    ]
+)
+def test_strip_header(data, expected):
+    """Removal of the 'CHANGELOG' header."""
+    make_release = pytest.importorskip("make_release")
+    assert make_release.strip_header(data) == expected
 
 
 def test_get_git_commits_since_tag():

tests/test_utils.py

@@ -387,7 +387,7 @@ def test_version_compare_equal_str():
 def test_version_compare_lt_str():
     a = Version("1.0")
     with pytest.raises(ValueError) as exc:
-        a < "1.0"  # noqa
+        a < "1.0"  # noqa: B015
     assert exc.value.args[0] == "Version cannot be compared against <class 'str'>"
 
 

tests/test_writer.py

@@ -651,9 +651,9 @@ def test_add_outline_item(pdf_file_path):
         reader = PdfReader(output_stream)
         assert reader.trailer["/Root"]["/Outlines"]["/Count"] == 3
         assert reader.outline[0]["/Count"] == -2
-        assert reader.outline[0]["/%is_open%"] == False  # noqa
+        assert reader.outline[0]["/%is_open%"] == False  # noqa: E712
         assert reader.outline[2]["/Count"] == 2
-        assert reader.outline[2]["/%is_open%"] == True  # noqa
+        assert reader.outline[2]["/%is_open%"] == True  # noqa: E712
         assert reader.outline[1][0]["/Count"] == 0