Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProcessedVariables: fix 2D scikit FEM bug #4912

Merged
merged 3 commits into from
Mar 11, 2025

Conversation

MarcBerliner
Copy link
Member

Description

The 2D scikit FEM observables were missing a transpose.

This PR also removes unused Python observable code, which was replaced by C++ code.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (6ad2495) to head (b2f05bc).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4912      +/-   ##
===========================================
- Coverage    98.71%   98.71%   -0.01%     
===========================================
  Files          304      304              
  Lines        23509    23478      -31     
===========================================
- Hits         23207    23176      -31     
  Misses         302      302              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MarcBerliner MarcBerliner marked this pull request as ready for review March 11, 2025 18:21
@MarcBerliner MarcBerliner requested a review from a team as a code owner March 11, 2025 18:21
@kratman kratman merged commit 2dcc015 into develop Mar 11, 2025
25 checks passed
@kratman kratman deleted the mdb/fix-2D-scikit-FEM-observed branch March 11, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants