Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change default solver to idaklu #4915

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

martinjrobins
Copy link
Contributor

@martinjrobins martinjrobins commented Mar 13, 2025

Description

Fixes #4914

Note: as part of this change I've had to relax a lot of the test tolerances, due to the different default tolerances that we have for the IDAKLU solver. If users have existing code that uses the default solver and tolerances, this might fail suddenly when they upgrade. We have to think about how to handle this

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python -m pytest (or $ nox -s tests)
  • The documentation builds: $ python -m pytest --doctest-plus src (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@martinjrobins martinjrobins requested a review from a team as a code owner March 13, 2025 20:01
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 86.79245% with 7 lines in your changes missing coverage. Please review.

Project coverage is 98.66%. Comparing base (4ba8cd8) to head (b65abc3).

Files with missing lines Patch % Lines
src/pybamm/solvers/idaklu_solver.py 85.71% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4915      +/-   ##
===========================================
- Coverage    98.71%   98.66%   -0.06%     
===========================================
  Files          304      304              
  Lines        23478    23514      +36     
===========================================
+ Hits         23176    23199      +23     
- Misses         302      315      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change default solver to idaklu
1 participant