You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have just opened a discussion on starlette about an issue when deleting cookies on their TestClient but it seems strongly related to httpx2.Client : Kludex/starlette#3373.
Based on cookiejar behaviour, it seems reasonable to update httpx2.Cookies to ensure that a dotted domain is set:
let set a domain in Cookies constructor when called with dict or list and ensure that this domain is dotted ;
ensure that the domain set to Cookies.set is dotted (see _models.py#L1104):
to Client.base_url.host + ".local" if no domain is provided in Cookies.set
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
I have just opened a discussion on
starletteabout an issue when deleting cookies on theirTestClientbut it seems strongly related tohttpx2.Client: Kludex/starlette#3373.Based on
cookiejarbehaviour, it seems reasonable to updatehttpx2.Cookiesto ensure that a dotted domain is set:Cookiesconstructor when called withdictorlistand ensure that this domain is dotted ;Cookies.setis dotted (see _models.py#L1104):Client.base_url.host + ".local"if no domain is provided in Cookies.sethttpx2/src/httpx2/httpx2/_models.py
Line 1104 in 70fac53
All reactions