Skip to content

Commit d9f9d30

Browse files
committed
fix broken test case where session.close() is needed
1 parent 428c9b5 commit d9f9d30

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

pyexcel_webio/__init__.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,12 @@ def get_records(self, sheet_name=None, name_columns_by_row=0, **keywords):
107107
else:
108108
return None
109109

110-
def save_to_database(self, session=None, table=None, sheet_name=None, name_columns_by_row=0, **keywords):
111-
sheet = self.load_single_sheet(sheet_name=sheet_name, name_columns_by_row=name_columns_by_row, **keywords)
110+
def save_to_database(self, session=None, table=None,
111+
sheet_name=None, name_columns_by_row=0, name_rows_by_column=-1, **keywords):
112+
sheet = self.load_single_sheet(sheet_name=sheet_name,
113+
name_columns_by_row=name_columns_by_row,
114+
name_rows_by_column=name_rows_by_column,
115+
**keywords)
112116
if sheet:
113117
sheet.save_to_database(session, table)
114118

tests/test_webio.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@ def test_save_to_database(self):
129129
myinput.save_to_database(filename=self.testfile, session=self.session, table=Signature,)
130130
array = pe.get_array(session=self.session, table=Signature)
131131
assert array == self.data
132+
self.session.close()
132133

133134
def tearDown(self):
134135
os.unlink(self.testfile)
@@ -167,6 +168,7 @@ def test_save_to_database(self):
167168
assert array == self.data
168169
array = pe.get_array(session=self.session, table=Signature2)
169170
assert array == self.data1
171+
self.session.close()
170172

171173
def tearDown(self):
172174
os.unlink(self.testfile)
@@ -212,12 +214,13 @@ def test_make_response_from_table(self):
212214
Base.metadata.create_all(engine)
213215
row1 = Signature(X=1,Y=2, Z=3)
214216
row2 = Signature(X=4, Y=5, Z=6)
215-
session =Session()
217+
session = Session()
216218
session.add(row1)
217219
session.add(row2)
218220
session.commit()
219221
webio.make_response_from_a_table(session, Signature, "xls")
220222
self.verify()
223+
session.close()
221224

222225
def verify(self):
223226
sheet2 = pe.load(OUTPUT)

0 commit comments

Comments
 (0)