From 16de7db04d808ee1ed3cfbbb7c0367b5474c7b84 Mon Sep 17 00:00:00 2001 From: Eric Wieser Date: Fri, 6 Dec 2019 16:26:40 +0000 Subject: [PATCH] Simplify `er_blade` This function did two things unnecessarily: * Convert blade reps to base rep before calling mul. This is already handled within `mul`, so there's no need to do it again at the call site. * Branch depending on the mode string - this branching is already handled by `Mul` --- galgebra/ga.py | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/galgebra/ga.py b/galgebra/ga.py index 0eb117ac..33c3b480 100644 --- a/galgebra/ga.py +++ b/galgebra/ga.py @@ -1650,22 +1650,10 @@ def er_blade(self, er, blade, mode='*', left=True): .. math:: e^{j}*(e_{i_{1}}\wedge ...\wedge e_{i_{r}}) """ - if mode == '*': - base = self.blade_to_base_rep(blade) - if left: - return self.base_to_blade_rep(self.mul(er, base)) - else: - return self.base_to_blade_rep(self.mul(base, er)) - elif mode == '^': - if left: - return self.wedge(er, blade) - else: - return self.wedge(blade, er) + if left: + return self.Mul(er, blade, mode=mode) else: - if left: - return self.Mul(er, blade, mode=mode) - else: - return self.Mul(blade, er, mode=mode) + return self.Mul(blade, er, mode=mode) def blade_derivation(self, blade, ib): """