Skip to content

Commit 2e661b8

Browse files
committed
Change defaults for sample params
1 parent 355c051 commit 2e661b8

File tree

2 files changed

+15
-66
lines changed

2 files changed

+15
-66
lines changed

nutpie/sample.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ def sample(
2424
compiled_model: CompiledModel,
2525
*,
2626
draws: int = 1000,
27-
tune: int = 1000,
28-
chains: int = 4,
27+
tune: int = 300,
28+
chains: int = 6,
2929
seed: int = 42,
3030
num_try_init=200,
3131
save_warmup: bool = True,

src/lib.rs

Lines changed: 13 additions & 64 deletions
Original file line numberDiff line numberDiff line change
@@ -434,53 +434,32 @@ impl PySamplerArgs {
434434
}
435435

436436
#[getter]
437-
fn variance_decay(&self) -> f64 {
438-
self.inner.mass_matrix_adapt.variance_decay
439-
}
440-
441-
#[setter(variance_decay)]
442-
fn set_variance_decay(&mut self, val: f64) {
443-
self.inner.mass_matrix_adapt.variance_decay = val;
444-
}
445-
446-
#[getter]
447-
fn early_variance_decay(&self) -> f64 {
448-
self.inner.mass_matrix_adapt.early_variance_decay
449-
}
450-
451-
#[setter(early_variance_decay)]
452-
fn set_early_variance_decay(&mut self, val: f64) {
453-
self.inner.mass_matrix_adapt.early_variance_decay = val;
454-
}
455-
456-
#[getter]
457-
fn use_grad_init(&self) -> bool {
458-
self.inner.mass_matrix_adapt.grad_init
437+
fn window_switch_freq(&self) -> u64 {
438+
self.inner.mass_matrix_adapt.mass_matrix_switch_freq
459439
}
460440

461-
#[setter(use_grad_init)]
462-
fn set_use_grad_init(&mut self, val: bool) {
463-
self.inner.mass_matrix_adapt.grad_init = val;
441+
#[setter(window_switch_freq)]
442+
fn set_window_switch_freq(&mut self, val: u64) {
443+
self.inner.mass_matrix_adapt.mass_matrix_switch_freq = val;
464444
}
465445

466446
#[getter]
467-
fn window_switch_freq(&self) -> u64 {
468-
self.inner.mass_matrix_adapt.window_switch_freq
447+
fn early_window_switch_freq(&self) -> u64 {
448+
self.inner.mass_matrix_adapt.early_mass_matrix_switch_freq
469449
}
470450

471451
#[setter(window_switch_freq)]
472-
fn set_window_switch_freq(&mut self, val: u64) {
473-
self.inner.mass_matrix_adapt.window_switch_freq = val;
452+
fn set_early_window_switch_freq(&mut self, val: u64) {
453+
self.inner.mass_matrix_adapt.early_mass_matrix_switch_freq = val;
474454
}
475-
476455
#[getter]
477456
fn initial_step(&self) -> f64 {
478-
self.inner.step_size_adapt.params.initial_step
457+
self.inner.step_size_adapt.initial_step
479458
}
480459

481460
#[setter(initial_step)]
482461
fn set_initial_step(&mut self, val: f64) {
483-
self.inner.step_size_adapt.params.initial_step = val
462+
self.inner.step_size_adapt.initial_step = val
484463
}
485464

486465
#[getter]
@@ -513,26 +492,6 @@ impl PySamplerArgs {
513492
self.inner.max_energy_error = val
514493
}
515494

516-
#[getter]
517-
fn mass_matrix_final_window(&self) -> u64 {
518-
self.inner.mass_matrix_adapt.final_window
519-
}
520-
521-
#[setter(mass_matrix_final_window)]
522-
fn set_mass_matrix_final_window(&mut self, val: u64) {
523-
self.inner.mass_matrix_adapt.final_window = val;
524-
}
525-
526-
#[getter]
527-
fn step_size_final_window_ratio(&self) -> f64 {
528-
self.inner.step_size_adapt.final_window_ratio
529-
}
530-
531-
#[setter(step_size_final_window_ratio)]
532-
fn set_step_size_final_window(&mut self, val: f64) {
533-
self.inner.step_size_adapt.final_window_ratio = val;
534-
}
535-
536495
#[setter(target_accept)]
537496
fn set_target_accept(&mut self, val: f64) {
538497
self.inner.step_size_adapt.target_accept = val;
@@ -543,24 +502,14 @@ impl PySamplerArgs {
543502
self.inner.step_size_adapt.target_accept
544503
}
545504

546-
#[getter]
547-
fn early_target_accept(&self) -> f64 {
548-
self.inner.step_size_adapt.early_target_accept
549-
}
550-
551-
#[setter(early_target_accept)]
552-
fn set_early_target_accept(&mut self, val: f64) {
553-
self.inner.step_size_adapt.early_target_accept = val;
554-
}
555-
556505
#[getter]
557506
fn store_mass_matrix(&self) -> bool {
558-
self.inner.mass_matrix_adapt.store_mass_matrix
507+
self.inner.mass_matrix_adapt.mass_matrix_options.store_mass_matrix
559508
}
560509

561510
#[setter(store_mass_matrix)]
562511
fn set_store_mass_matrix(&mut self, val: bool) {
563-
self.inner.mass_matrix_adapt.store_mass_matrix = val;
512+
self.inner.mass_matrix_adapt.mass_matrix_options.store_mass_matrix = val;
564513
}
565514
}
566515

0 commit comments

Comments
 (0)