New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove requirement of channel dims for media transformation #1473

Open

wd60622 opened this issue Feb 6, 2025 · 0 comments

Labels

media transforms MMM

Contributor

wd60622 commented Feb 6, 2025

This can be relax and have the user do:

pymc-marketing/pymc_marketing/mmm/mmm.py

Lines 634 to 637 in 6667e9d

    
           for media_transform in [self.adstock, self.saturation]: 
        
               for dist in media_transform.function_priors.values(): 
        
                   if dist.dims != ("channel",): 
        
                       dist.dims = "channel"

github-actions bot added the Needs Triage label

wd60622 added MMM media transforms and removed Needs Triage labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment