Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broken pre-commit ci #1476

Open
wd60622 opened this issue Feb 7, 2025 · 4 comments
Open

broken pre-commit ci #1476

wd60622 opened this issue Feb 7, 2025 · 4 comments
Labels
no releasenotes

Comments

@wd60622
Copy link
Contributor

wd60622 commented Feb 7, 2025

I know there is an open source one that we can run like any other action

Thoughts @juanitorduz
@juanitorduz juanitorduz mentioned this issue Feb 7, 2025
Merged
@juanitorduz
Copy link
Collaborator

You mean like #1477 ?

This won't update the pre-commit versions

@wd60622
Copy link
Contributor Author

wd60622 commented Feb 7, 2025

The PRs should still be created. The CI will just continue to fail. Is there a way to disable CI but not the PRs by pre-commit bot?

@juanitorduz
Copy link
Collaborator

We just merged the pre-commit check so we can bypass the failing one. Let's wait a week and see if it gets fixed. We had a similar issue last year. Maybe we re evaluate the approach depending on this ?

@juanitorduz
Copy link
Collaborator

Ahg! It is mypy being too slow c602666!

@juanitorduz juanitorduz mentioned this issue Feb 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
no releasenotes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juanitorduz @wd60622