rp2350 pc_EraseAll is wrong in target_rp2.py on develop

[rgrr]

Is this just a typo or really wrong?:

https://github.com/pyocd/pyOCD/blob/develop/pyocd/target/family/target_rp2.py#L65

[rgrr]

perhaps @konkers knows best?

[hagibr]

A workaround could be to comment the line with pc_eraseAll for now. pyOCD will call the function at pc_erase_sector multiple times instead. I had to do this for my self generated builtin for EFR32BG24, because the algorithm from CMSIS-Pack was implemented wrong. Internally, EraseChip() was calling EraseSector() multiple times but starting at address 0x0, where it should be starting at address 0x08000000. Another way they could accomplish this was to actually execute the mass erase routine, but I think they were lazy or incompetent.