Backport wheel filename normalization into a Python 3.8 and 3.7 compatible release

[di]

There are some users who still need to build/release Python 3.8 wheels that can't use newer setuptools versions with #4766 in it.

I propose the following:

• create a new temporary v75.3.1 branch from https://github.com/pypa/setuptools/releases/tag/v75.3.0 (d8da7df), the last commit/release to support Python 3.8
• merge a PR targeting this new branch backporting Fix "Wheel naming is not following PEP 491 convention" #4766
• tag the branch at v75.3.1 & release version 75.3.1
• merge a PR targeting main retconning this release into the changelog

If this sounds good, @jaraco/@abravalheri, could one of you create the temporary v75.3.1 branch?

[jaraco]

Here's what I did to enact the backport:

 setuptools main 🐚 git checkout v75.3.0
HEAD is now at d8da7dfaa Bump version: 75.2.0 → 75.3.0
 setuptools d8da7dfaa 🐚 git log main --grep "Merge pull request #4766"
commit 75f77825a816933088bc07ec290d9e2ef700a8ee
Merge: a443f7647 8ba79d9db
Author: Jason R. Coombs <jaraco@jaraco.com>
Date:   Sun Feb 2 13:59:22 2025 -0500

    Merge pull request #4766 from di/fix/3777
    
    Fix "Wheel naming is not following PEP 491 convention"
 setuptools d8da7dfaa 🐚 git cherry-pick 75f77825 -m 1
Auto-merging setuptools/command/bdist_wheel.py
CONFLICT (content): Merge conflict in setuptools/command/bdist_wheel.py
Auto-merging setuptools/tests/test_bdist_wheel.py
Auto-merging setuptools/tests/test_dist.py
CONFLICT (content): Merge conflict in setuptools/tests/test_dist.py
Auto-merging setuptools/tests/test_dist_info.py
Auto-merging setuptools/tests/test_easy_install.py
CONFLICT (content): Merge conflict in setuptools/tests/test_easy_install.py
error: could not apply 75f77825a... Merge pull request #4766 from di/fix/3777
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Recorded preimage for 'setuptools/command/bdist_wheel.py'
Recorded preimage for 'setuptools/tests/test_dist.py'
Recorded preimage for 'setuptools/tests/test_easy_install.py'
 setuptools d8da7dfaa [1] 🐚 git mergetool
Merging:
setuptools/command/bdist_wheel.py
setuptools/tests/test_dist.py
setuptools/tests/test_easy_install.py

Normal merge conflict for 'setuptools/command/bdist_wheel.py':
  {local}: modified file
  {remote}: modified file

Normal merge conflict for 'setuptools/tests/test_dist.py':
  {local}: modified file
  {remote}: modified file

Normal merge conflict for 'setuptools/tests/test_easy_install.py':
  {local}: modified file
  {remote}: modified file
 setuptools d8da7dfaa [128] 🐚 git cherry-pick --continue
Recorded resolution for 'setuptools/command/bdist_wheel.py'.
Recorded resolution for 'setuptools/tests/test_dist.py'.
Recorded resolution for 'setuptools/tests/test_easy_install.py'.
[detached HEAD 9559193e1] Merge pull request #4766 from di/fix/3777
 Date: Sun Feb 2 13:59:22 2025 -0500
 7 files changed, 25 insertions(+), 24 deletions(-)
 create mode 100644 newsfragments/4766.bugfix.rst
 setuptools 9559193e1 🐚 git mv newsfragments/4766.bugfix.rst newsfragments/4877.bugfix.rst
 setuptools 9559193e1 🐚 git commit -a -m "Repoint the news fragment."
[detached HEAD 1740976b2] Repoint the news fragment.
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename newsfragments/{4766.bugfix.rst => 4877.bugfix.rst} (100%)
 setuptools 1740976b2 🐚 tox -e finalize
finalize: install_deps> python -I -m pip install bump2version 'importlib_resources<6' 'jaraco.develop>=7.23' towncrier
finalize: commands[0]> python tools/finalize.py
Reading config file .bumpversion.cfg:
[bumpversion]
current_version = 75.3.0
commit = True
tag = True

[bumpversion:file:pyproject.toml]

Attempting to increment part 'patch'
Values are now: major=75, minor=3, patch=1
Dry run active, won't touch any files.
New version will be '75.3.1'
Asserting files pyproject.toml contain the version string...
Would write to config file .bumpversion.cfg:
[bumpversion]
current_version = 75.3.1
commit = True
tag = True

[bumpversion:file:pyproject.toml]


Would prepare Git commit
Would add changes in file 'pyproject.toml' to Git
Would add changes in file '.bumpversion.cfg' to Git
Would commit to Git with message 'Bump version: 75.3.0 → 75.3.1'
Would tag 'v75.3.1' with message 'Bump version: 75.3.0 → 75.3.1' in Git and not signing
Cutting release at 75.3.1
Loading template...
Finding news fragments...
Rendering news fragments...
Writing to newsfile...
Staging newsfile...
Removing the following files:
/Users/jaraco/code/pypa/setuptools/newsfragments/4877.bugfix.rst
Removing news fragments...
Done!
  finalize: OK (1.82=setup[1.04]+cmd[0.78] seconds)
  congratulations :) (1.91 seconds)
 setuptools 23b7b529c 🐚 git checkout -b bugfix/wheel-name
Switched to a new branch 'bugfix/wheel-name'
 setuptools bugfix/wheel-name 🐚 git checkout 23b7b529c
HEAD is now at 23b7b529c Bump version: 75.3.0 → 75.3.1
 setuptools 23b7b529c 🐚 git checkout -b bugfix/wheel-name-backport
Switched to a new branch 'bugfix/wheel-name-backport'
 setuptools bugfix/wheel-name-backport 🐚 git push
Enumerating objects: 36, done.
Counting objects: 100% (36/36), done.
Delta compression using up to 12 threads
Compressing objects: 100% (22/22), done.
Writing objects: 100% (22/22), 5.13 KiB | 5.13 MiB/s, done.
Total 22 (delta 15), reused 1 (delta 0), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (15/15), completed with 12 local objects.
To https://github.com/pypa/setuptools
 * [new branch]          bugfix/wheel-name-backport -> bugfix/wheel-name-backport
 * [new tag]             v75.3.1 -> v75.3.1
branch 'bugfix/wheel-name-backport' set up to track 'origin/bugfix/wheel-name-backport'.
 setuptools bugfix/wheel-name-backport 🐚 gh pr create

Creating pull request for bugfix/wheel-name-backport into main in pypa/setuptools

? Title (required) Backport bugfix for wheel naming for Python 3.8
? Choose a template pull_request_template.md
? Body <Received>
? What's next? Submit
https://github.com/pypa/setuptools/pull/4879

[jaraco]

Fixed in v75.3.2 (and v75.3.1).

[di]

Thanks @jaraco, I appreciate it. Depending on how much effort that was, would you be up for doing the same for 3.7? The last release that supported 3.7 was https://github.com/pypa/setuptools/releases/tag/v68.0.0. Happy to create the PR myself if that would be helpful, and I expect that this is the last Python version it would be reasonable to backport for.

[jaraco]

Knowing what I know now, it shouldn't be too difficult. I'll give it a go. Thanks for the offer.

[jaraco]

I started working on the backport, but realize now that the bdist_wheel command did not exist in Setuptools in v68. And although wheel is vendored in that version of Setuptools, it's not mentioned in the vendored names, which makes me think it will prefer the implementation as installed. Therefore, the way for Python 3.7 users to get this behavior will be to adopt a version of wheel that supports this behavior.

Unfortunately, I don't think there's any such release of wheel that supports this behavior (ref). Probably, the change will need to be contributed to wheel to get the behavior on Python 3.7 unless a rather invasive workaround (monkeypatch?) is implemented in Setuptools.

@di Given these findings, what would you recommend?

[di]

Thanks for the attempt. I agree, going that length for a Python version that is well past EOL is probably not worthwhile. I'll explore a backport in wheel, doesn't seem like there's anything else for setuptools to do here. Thanks again!

[Houbein]

I REALLY wish you had not even tried this backporting in any way.
People have had YEARS to migrate their Python versions.
Please never backport in this way again, just force people to update. Again, they have had YEARS at this point.
LCM or die.