From 613cafb647ac53448b5222180db1b25c3d17db9c Mon Sep 17 00:00:00 2001
From: geisserml <geisserml@gmail.com>
Date: Thu, 23 Jan 2025 21:25:48 +0100
Subject: [PATCH] (Experimental:) Isolate conda

---
 .github/workflows/conda.yaml               |   3 +-
 README.md                                  |   4 +-
 conda/craft_conda_pkgs.py                  | 175 ++++++++++++++
 conda/prepare_script.py                    |   4 +-
 docs/devel/changelog_staging.md            |   1 +
 run                                        |   7 +-
 setup.py                                   |   2 +-
 setupsrc/pypdfium2_setup/craft.py          | 131 +++++++++++
 setupsrc/pypdfium2_setup/craft_packages.py | 259 ---------------------
 setupsrc/pypdfium2_setup/emplace.py        |   2 +-
 setupsrc/pypdfium2_setup/packaging_base.py |  35 +--
 11 files changed, 323 insertions(+), 300 deletions(-)
 create mode 100644 conda/craft_conda_pkgs.py
 create mode 100644 setupsrc/pypdfium2_setup/craft.py
 delete mode 100644 setupsrc/pypdfium2_setup/craft_packages.py

diff --git a/.github/workflows/conda.yaml b/.github/workflows/conda.yaml
index 5bd3808bf..1ac220267 100644
--- a/.github/workflows/conda.yaml
+++ b/.github/workflows/conda.yaml
@@ -62,8 +62,9 @@ jobs:
           git config --global user.name "geisserml"
           python -m pip install -U -r req/setup.txt
       
+      # TODO make --new-only optional
       - name: Build package
-        run: ./run craft --pdfium-ver "${{ inputs.pdfium_ver }}" conda_${{ inputs.package }}
+        run: ./run craft-conda ${{ inputs.package }} --pdfium-ver "${{ inputs.pdfium_ver }}" --new-only
       
       - name: Upload artifact
         uses: actions/upload-artifact@v4
diff --git a/README.md b/README.md
index a287f163f..80b7fd013 100644
--- a/README.md
+++ b/README.md
@@ -789,7 +789,7 @@ You may also trigger the workflow manually using the GitHub Actions panel or the
 
 Python release scripts are located in the folder `setupsrc/pypdfium2_setup`, along with custom setup code:
 * `update_pdfium.py` downloads binaries.
-* `craft_packages.py pypi` builds platform-specific wheel packages and a source distribution suitable for PyPI upload.
+* `craft.py` builds platform-specific wheel packages and a source distribution suitable for PyPI upload.
 * `autorelease.py` takes care of versioning, changelog, release note generation and VCS checkin.
 
 The autorelease script has some peculiarities maintainers should know about:
@@ -815,7 +815,7 @@ In case of necessity, you may also forego autorelease/CI and do the release manu
 * Build the packages
   ```bash
   python setupsrc/pypdfium2_setup/update_pdfium.py
-  python setupsrc/pypdfium2_setup/craft_packages.py pypi
+  python setupsrc/pypdfium2_setup/craft.py
   ```
 * Upload to PyPI
   ```bash
diff --git a/conda/craft_conda_pkgs.py b/conda/craft_conda_pkgs.py
new file mode 100644
index 000000000..97bdee109
--- /dev/null
+++ b/conda/craft_conda_pkgs.py
@@ -0,0 +1,175 @@
+# SPDX-FileCopyrightText: 2024 geisserml <geisserml@gmail.com>
+# SPDX-License-Identifier: Apache-2.0 OR BSD-3-Clause
+
+import sys
+import argparse
+from pathlib import Path
+from functools import partial
+
+sys.path.insert(0, str(Path(__file__).parents[1]/"setupsrc"))
+from pypdfium2_setup.packaging_base import *
+from pypdfium2_setup.emplace import prepare_setup
+
+CondaDir = ProjectDir / "conda"
+CondaRaw_BuildNumF = CondaDir / "raw" / "build_num.txt"
+
+T_RAW = "raw"
+T_HELPERS = "helpers"
+
+
+def main():
+    parser = argparse.ArgumentParser(
+        description = "Craft conda packages for pypdfium2"
+    )
+    parser.add_argument(
+        "type",
+        choices = (T_RAW, T_HELPERS),
+        help = "The package type to build (raw or helpers)",
+    )
+    parser.add_argument("--pdfium-ver", default=None)
+    parser.add_argument("--new-only", action="store_true")
+    
+    args = parser.parse_args()
+    if args.type == T_RAW:
+        main_conda_raw(args)
+    elif args.type == T_HELPERS:
+        assert not args.new_only, "--new-only / buildnum handling not implemented for helpers package"
+        main_conda_helpers(args)
+    else:
+        assert False  # unreached, handled by argparse
+
+
+def _handle_ver(args, get_latest):
+    if not args.pdfium_ver or args.pdfium_ver == "latest":
+        args.pdfium_ver = get_latest()
+    else:
+        args.pdfium_ver = int(args.pdfium_ver)
+
+
+def main_conda_raw(args):
+    
+    _handle_ver(args, CondaPkgVer.get_latest_pdfium)
+    os.environ["PDFIUM_SHORT"] = str(args.pdfium_ver)
+    os.environ["PDFIUM_FULL"] = ".".join([str(v) for v in PdfiumVer.to_full(args.pdfium_ver)])
+    os.environ["BUILD_NUM"] = str(_get_build_num(args))
+    
+    emplace_func = partial(prepare_setup, ExtPlats.system, args.pdfium_ver, use_v8=None)
+    with CondaExtPlatfiles(emplace_func):
+        run_conda_build(CondaDir/"raw", CondaDir/"raw"/"out", args=["--override-channels", "-c", "bblanchon", "-c", "defaults"])
+
+
+def main_conda_helpers(args):
+    
+    _handle_ver(args, CondaPkgVer.get_latest_bindings)
+    helpers_info = parse_git_tag()
+    os.environ["M_HELPERS_VER"] = merge_tag(helpers_info, "py")
+    
+    # Set the current pdfium version as upper boundary, for inherent API safety.
+    # pdfium does not do semantic versioning, so upward flexibility is difficult.
+    os.environ["PDFIUM_MAX"] = str(args.pdfium_ver)
+    
+    # NOTE To build with a local pypdfium2_raw, add the args below for the source dir, and remove the pypdfium2-team prefix from the helpers recipe's run requirements
+    # args=["-c", CondaDir/"raw"/"out"]
+    run_conda_build(CondaDir/"helpers", CondaDir/"helpers"/"out", args=["--override-channels", "-c", "pypdfium2-team", "-c", "bblanchon", "-c", "defaults"])
+
+
+def run_conda_build(recipe_dir, out_dir, args=()):
+    with TmpCommitCtx():
+        run_cmd(["conda", "build", recipe_dir, "--output-folder", out_dir, *args], cwd=ProjectDir, env=os.environ)
+
+
+@functools.lru_cache(maxsize=2)
+def run_conda_search(package, channel):
+    output = run_cmd(["conda", "search", "--json", package, "--override-channels", "-c", channel], cwd=None, capture=True)
+    return json.loads(output)[package]
+
+
+class CondaPkgVer:
+
+    @staticmethod
+    @functools.lru_cache(maxsize=2)
+    def _get_latest_for(package, channel, v_func):
+        search = run_conda_search(package, channel)
+        search = sorted(search, key=lambda d: v_func(d["version"]), reverse=True)
+        result = v_func(search[0]["version"])
+        print(f"Resolved latest {channel}::{package} to {result}", file=sys.stderr)
+        return result
+    
+    @staticmethod
+    def get_latest_pdfium():
+        return CondaPkgVer._get_latest_for(
+            "pdfium-binaries", "bblanchon", lambda v: int(v.split(".")[2])
+        )
+    
+    @staticmethod
+    def get_latest_bindings():
+        return CondaPkgVer._get_latest_for(
+            "pypdfium2_raw", "pypdfium2-team", lambda v: int(v)
+        )
+
+
+def _get_build_num(args):
+    
+    # parse existing releases to automatically handle arbitrary version builds
+    # TODO expand to pypdfium2_helpers as well, so we could rebuild with different pdfium bounds in a workflow
+    
+    search = reversed(run_conda_search("pypdfium2_raw", "pypdfium2-team"))
+    
+    if args.new_only:
+        # or `args.pdfium_ver not in {...}` to allow new builds of older versions
+        assert args.pdfium_ver > max(int(d["version"]) for d in search), f"--new-only given, but {args.pdfium_ver} already has a build"
+    
+    # determine build number
+    build_num = max((d["build_number"] for d in search if int(d["version"]) == args.pdfium_ver), default=None)
+    build_num = 0 if build_num is None else build_num+1
+    
+    return build_num
+
+
+class TmpCommitCtx:
+    
+    # Work around local conda `git_url` not including uncommitted changes
+    # In particular, this is used to transfer data files, so we can generate them externally and don't have to conda package ctypesgen.
+    
+    # use a tmp control file so we can also undo the commit in conda's isolated clone
+    FILE = CondaDir / "with_tmp_commit.txt"
+    
+    def __enter__(self):
+        # determine if there are any modified or new files
+        out = run_cmd(["git", "status", "--porcelain"], capture=True, cwd=ProjectDir)
+        self.have_mods = bool(out)
+        if self.have_mods:  # make tmp commit
+            self.FILE.touch()
+            run_cmd(["git", "add", "."], cwd=ProjectDir)
+            run_cmd(["git", "commit", "-m", "!!! tmp commit for conda-build", "-m", "make conda-build include uncommitted changes"], cwd=ProjectDir)
+    
+    @classmethod
+    def undo(cls):
+        # assuming FILE exists (promised by callers)
+        run_cmd(["git", "reset", "--soft", "HEAD^"], cwd=ProjectDir)
+        run_cmd(["git", "reset", cls.FILE], cwd=ProjectDir)
+        cls.FILE.unlink()
+    
+    def __exit__(self, *_):
+        if self.have_mods:  # pop tmp commit, if any
+            self.undo()
+
+
+class CondaExtPlatfiles:
+    
+    def __init__(self, emplace_func):
+        self.emplace_func = emplace_func
+    
+    def __enter__(self):
+        self.platfiles = self.emplace_func()
+        self.platfiles = [ModuleDir_Raw/f for f in self.platfiles]
+        run_cmd(["git", "add", "-f"] + [str(f) for f in self.platfiles], cwd=ProjectDir)
+    
+    def __exit__(self, *_):
+        run_cmd(["git", "reset"] + [str(f) for f in self.platfiles], cwd=ProjectDir)
+        for fp in self.platfiles:
+            fp.unlink()
+
+
+if __name__ == "__main__":
+    main()
diff --git a/conda/prepare_script.py b/conda/prepare_script.py
index 513263d39..ca3c28234 100644
--- a/conda/prepare_script.py
+++ b/conda/prepare_script.py
@@ -4,8 +4,8 @@
 import sys
 from pathlib import Path
 
-sys.path.insert(0, str(Path(__file__).parents[1] / "setupsrc"))
-from pypdfium2_setup.craft_packages import TmpCommitCtx
+sys.path.insert(0, str(Path(__file__).parents[1] / "conda"))
+from craft_conda_pkgs import TmpCommitCtx
 
 def main():
     if TmpCommitCtx.FILE.exists():
diff --git a/docs/devel/changelog_staging.md b/docs/devel/changelog_staging.md
index 8d76d2e60..c15577b70 100644
--- a/docs/devel/changelog_staging.md
+++ b/docs/devel/changelog_staging.md
@@ -40,6 +40,7 @@
 *Project*
 - Merged `tests_old/` back into `tests/`.
 - Docs: Improved logic when to include the unreleased version warning and upcoming changelog.
+- Cleanly split out conda packaging into an own file, and confined it to the `conda/` directory, to avoid polluting the main setup code.
 
 <!-- TODO
 See https://github.com/pypdfium2-team/pypdfium2/blob/devel_old/docs/devel/changelog_staging.md
diff --git a/run b/run
index e7c51bc7a..69a6ff59e 100755
--- a/run
+++ b/run
@@ -23,7 +23,7 @@ function packaging_pypi() {
 
     # calling update_pdfium is not strictly necessary, but may improve performance because downloads are done in parallel, rather than linear with each package
     python3 setupsrc/pypdfium2_setup/update_pdfium.py
-    python3 setupsrc/pypdfium2_setup/craft_packages.py pypi
+    python3 setupsrc/pypdfium2_setup/craft.py
 
     twine check dist/*
     # ignore W002: erroneous detection of __init__.py files as duplicates
@@ -60,7 +60,10 @@ update)
     python3 setupsrc/pypdfium2_setup/update_pdfium.py $args;;
 
 craft)
-    python3 setupsrc/pypdfium2_setup/craft_packages.py $args;;
+    python3 setupsrc/pypdfium2_setup/craft.py $args;;
+
+craft-conda)
+    python3 conda/craft_conda_pkgs.py $args;;
 
 build)
     python3 setupsrc/pypdfium2_setup/build_pdfium.py $args;;
diff --git a/setup.py b/setup.py
index b9ebb9633..e4c947581 100644
--- a/setup.py
+++ b/setup.py
@@ -104,7 +104,7 @@ def run_setup(modnames, pl_name, pdfium_ver):
         helpers_info = get_helpers_info()
         if pl_name == ExtPlats.sdist:
             if helpers_info["dirty"]:
-                # ignore dirty state due to craft_packages::tmp_ctypesgen_pin()
+                # ignore dirty state due to craft.py::tmp_ctypesgen_pin()
                 if int(os.environ.get("SDIST_IGNORE_DIRTY", 0)):
                     helpers_info["dirty"] = False
             else:
diff --git a/setupsrc/pypdfium2_setup/craft.py b/setupsrc/pypdfium2_setup/craft.py
new file mode 100644
index 000000000..5977b15c3
--- /dev/null
+++ b/setupsrc/pypdfium2_setup/craft.py
@@ -0,0 +1,131 @@
+# SPDX-FileCopyrightText: 2024 geisserml <geisserml@gmail.com>
+# SPDX-License-Identifier: Apache-2.0 OR BSD-3-Clause
+
+import os
+import sys
+import json
+import shutil
+import argparse
+import tempfile
+import contextlib
+import urllib.request as url_request
+from pathlib import Path
+
+sys.path.insert(0, str(Path(__file__).parents[1]))
+from pypdfium2_setup.packaging_base import *
+
+try:
+    import build.__main__ as build_module
+except ImportError:
+    build_module = None
+
+
+def main():
+    
+    parser = argparse.ArgumentParser(
+        description = "Craft PyPI packages for pypdfium2"
+    )
+    parser.add_argument("--pdfium-ver", default=None)
+    parser.add_argument("--use-v8", action="store_true")
+    parser.add_argument("--wheels", action="store_true")
+    parser.add_argument("--sdist", action="store_true")
+    
+    args = parser.parse_args()
+    if not (args.wheels or args.sdist):
+        args.wheels, args.sdist = True, True
+    if not args.pdfium_ver or args.pdfium_ver == "latest":
+        args.pdfium_ver = PdfiumVer.get_latest()
+    else:
+        args.pdfium_ver = int(args.pdfium_ver)
+    
+    with ArtifactStash():
+        main_pypi(args)
+
+
+def main_pypi(args):
+    
+    assert args.sdist or args.wheels
+    
+    if args.sdist:
+        os.environ[PlatSpec_EnvVar] = ExtPlats.sdist
+        helpers_info = get_helpers_info()
+        with tmp_ctypesgen_pin():
+            if not helpers_info["dirty"]:
+                os.environ["SDIST_IGNORE_DIRTY"] = "1"
+            _run_pypi_build(["--sdist"])
+    
+    if args.wheels:
+        suffix = build_pl_suffix(args.pdfium_ver, args.use_v8)
+        for plat in WheelPlatforms:
+            os.environ[PlatSpec_EnvVar] = plat + suffix
+            _run_pypi_build(["--wheel"])
+            clean_platfiles()
+
+
+def _run_pypi_build(caller_args):
+    # -nx: --no-isolation --skip-dependency-check
+    assert build_module, "Module 'build' is not importable. Cannot craft PyPI packages."
+    with tmp_cwd_context(ProjectDir):
+        build_module.main([str(ProjectDir), "-nx", *caller_args])
+
+
+class ArtifactStash:
+    
+    # Preserve in-tree artifacts from editable install
+    
+    def __enter__(self):
+        
+        self.tmpdir = None
+        
+        file_names = [VersionFN, BindingsFN, LibnameForSystem[Host.system]]
+        self.files = [fp for fp in [ModuleDir_Raw / fn for fn in file_names] if fp.exists()]
+        if len(self.files) == 0:
+            return
+        
+        self.tmpdir = tempfile.TemporaryDirectory(prefix="pypdfium2_artifact_stash_")
+        self.tmpdir_path = Path(self.tmpdir.name)
+        for fp in self.files:
+            shutil.move(fp, self.tmpdir_path)
+    
+    def __exit__(self, *_):
+        if self.tmpdir is None:
+            return
+        for fp in self.files:
+            shutil.move(self.tmpdir_path / fp.name, ModuleDir_Raw)
+        self.tmpdir.cleanup()
+
+
+@contextlib.contextmanager
+def tmp_replace_ctx(fp, orig, tmp):
+    orig_txt = fp.read_text()
+    assert orig_txt.count(orig) == 1
+    tmp_txt = orig_txt.replace(orig, tmp)
+    fp.write_text(tmp_txt)
+    try:
+        yield
+    finally:
+        fp.write_text(orig_txt)
+
+
+@contextlib.contextmanager
+def tmp_ctypesgen_pin():
+    
+    pin = os.environ.get("CTYPESGEN_PIN", None)
+    if not pin:
+        head_url = "https://api.github.com/repos/pypdfium2-team/ctypesgen/git/refs/heads/pypdfium2"
+        with url_request.urlopen(head_url) as rq:
+            content = rq.read().decode()
+        content = json.loads(content)
+        pin = content["object"]["sha"]
+        print(f"Resolved pypdfium2 ctypesgen HEAD to SHA {pin}", file=sys.stderr)
+    
+    base_txt = "ctypesgen @ git+https://github.com/pypdfium2-team/ctypesgen@"
+    ctx = tmp_replace_ctx(ProjectDir/"pyproject.toml", base_txt+"pypdfium2", base_txt+pin)
+    with ctx:
+        print(f"Wrote temporary pyproject.toml with ctypesgen pin", file=sys.stderr)
+        yield
+    print(f"Reset pyproject.toml", file=sys.stderr)
+
+
+if __name__ == '__main__':
+    main()
diff --git a/setupsrc/pypdfium2_setup/craft_packages.py b/setupsrc/pypdfium2_setup/craft_packages.py
deleted file mode 100644
index 813cc14f4..000000000
--- a/setupsrc/pypdfium2_setup/craft_packages.py
+++ /dev/null
@@ -1,259 +0,0 @@
-# SPDX-FileCopyrightText: 2024 geisserml <geisserml@gmail.com>
-# SPDX-License-Identifier: Apache-2.0 OR BSD-3-Clause
-
-# TODO split in pypi and conda?
-
-import os
-import sys
-import json
-import shutil
-import argparse
-import tempfile
-import contextlib
-import urllib.request as url_request
-from pathlib import Path
-from functools import partial
-
-sys.path.insert(0, str(Path(__file__).parents[1]))
-# TODO consider dotted access?
-from pypdfium2_setup.packaging_base import *
-from pypdfium2_setup.emplace import prepare_setup
-
-try:
-    import build.__main__ as build_module
-except ImportError:
-    build_module = None
-
-
-P_PYPI = "pypi"
-P_CONDA_RAW = "conda_raw"
-P_CONDA_HELPERS = "conda_helpers"
-
-def parse_args():
-    
-    root_parser = argparse.ArgumentParser(
-        description = "Craft PyPI or conda packages for pypdfium2.",
-    )
-    root_parser.add_argument(
-        "--pdfium-ver",
-        default = None,
-    )
-    subparsers = root_parser.add_subparsers(dest="parser")
-    pypi = subparsers.add_parser(P_PYPI)
-    pypi.add_argument("--use-v8", action="store_true")
-    pypi.add_argument("--wheels", action="store_true")
-    pypi.add_argument("--sdist", action="store_true")
-    conda_raw = subparsers.add_parser(P_CONDA_RAW)
-    conda_helpers = subparsers.add_parser(P_CONDA_HELPERS)
-    
-    args = root_parser.parse_args()
-    
-    if args.parser == P_PYPI:
-        if not (args.wheels or args.sdist):
-            args.wheels, args.sdist = True, True
-    
-    args.is_literal_latest = args.pdfium_ver == "latest"
-    if not args.pdfium_ver or args.is_literal_latest:
-        if args.parser == P_CONDA_RAW:
-            args.pdfium_ver = PdfiumVer.get_latest_conda_pdfium()
-        elif args.parser == P_CONDA_HELPERS:
-            args.pdfium_ver = PdfiumVer.get_latest_conda_bindings()
-        else:
-            args.pdfium_ver = PdfiumVer.get_latest()
-    else:
-        args.pdfium_ver = int(args.pdfium_ver)
-    
-    return args
-
-
-def main():
-    
-    args = parse_args()
-    
-    with ArtifactStash():
-        if args.parser == P_PYPI:
-            main_pypi(args)
-        elif args.parser == P_CONDA_RAW:
-            main_conda_raw(args)
-        elif args.parser == P_CONDA_HELPERS:
-            helpers_info = parse_git_tag()
-            os.environ["M_HELPERS_VER"] = merge_tag(helpers_info, "py")
-            main_conda_helpers(args)
-        else:
-            assert False
-
-
-def _run_pypi_build(caller_args):
-    # -nx: --no-isolation --skip-dependency-check
-    assert build_module, "Module 'build' is not importable. Cannot craft PyPI packages."
-    with tmp_cwd_context(ProjectDir):
-        build_module.main([str(ProjectDir), "-nx", *caller_args])
-
-
-def main_pypi(args):
-    
-    assert args.sdist or args.wheels
-    
-    if args.sdist:
-        os.environ[PlatSpec_EnvVar] = ExtPlats.sdist
-        helpers_info = get_helpers_info()
-        with tmp_ctypesgen_pin():
-            if not helpers_info["dirty"]:
-                os.environ["SDIST_IGNORE_DIRTY"] = "1"
-            _run_pypi_build(["--sdist"])
-    
-    if args.wheels:
-        suffix = build_pl_suffix(args.pdfium_ver, args.use_v8)
-        for plat in WheelPlatforms:
-            os.environ[PlatSpec_EnvVar] = plat + suffix
-            _run_pypi_build(["--wheel"])
-            clean_platfiles()
-
-
-def run_conda_build(recipe_dir, out_dir, args=()):
-    with TmpCommitCtx():
-        run_cmd(["conda", "build", recipe_dir, "--output-folder", out_dir, *args], cwd=ProjectDir, env=os.environ)
-
-
-def _get_build_num(args):
-    
-    # parse existing releases to automatically handle arbitrary version builds
-    # TODO expand to pypdfium2_helpers as well, so we could rebuild with different pdfium bounds in a workflow
-    
-    search = reversed(run_conda_search("pypdfium2_raw", "pypdfium2-team"))
-    
-    if args.is_literal_latest:
-        assert args.pdfium_ver > max([int(d["version"]) for d in search]), "Literal latest must resolve to a new version. This is done to avoid rebuilds without new version in scheduled releases. If you want to rebuild, omit --pdfium-ver or pass the resolved value."
-    
-    # determine build number
-    build_num = max([d["build_number"] for d in search if int(d["version"]) == args.pdfium_ver], default=None)
-    build_num = 0 if build_num is None else build_num+1
-    
-    return build_num
-
-
-def main_conda_raw(args):
-    os.environ["PDFIUM_SHORT"] = str(args.pdfium_ver)
-    os.environ["PDFIUM_FULL"] = ".".join([str(v) for v in PdfiumVer.to_full(args.pdfium_ver)])
-    os.environ["BUILD_NUM"] = str(_get_build_num(args))
-    emplace_func = partial(prepare_setup, ExtPlats.system, args.pdfium_ver, use_v8=None)
-    with CondaExtPlatfiles(emplace_func):
-        run_conda_build(CondaDir/"raw", CondaDir/"raw"/"out", args=["--override-channels", "-c", "bblanchon", "-c", "defaults"])
-
-
-def main_conda_helpers(args):
-    
-    # Set the current pdfium version as upper boundary, for inherent API safety.
-    # pdfium does not do semantic versioning, so upward flexibility is difficult.
-    os.environ["PDFIUM_MAX"] = str(args.pdfium_ver)
-    
-    # NOTE To build with a local pypdfium2_raw, add the args below for the source dir, and remove the pypdfium2-team prefix from the helpers recipe's run requirements
-    # args=["-c", CondaDir/"raw"/"out"]
-    run_conda_build(CondaDir/"helpers", CondaDir/"helpers"/"out", args=["--override-channels", "-c", "pypdfium2-team", "-c", "bblanchon", "-c", "defaults"])
-
-
-class ArtifactStash:
-    
-    # Preserve in-tree aftefacts from editable install
-    
-    def __enter__(self):
-        
-        self.tmpdir = None
-        
-        file_names = [VersionFN, BindingsFN, LibnameForSystem[Host.system]]
-        self.files = [fp for fp in [ModuleDir_Raw / fn for fn in file_names] if fp.exists()]
-        if len(self.files) == 0:
-            return
-        
-        self.tmpdir = tempfile.TemporaryDirectory(prefix="pypdfium2_artifact_stash_")
-        self.tmpdir_path = Path(self.tmpdir.name)
-        for fp in self.files:
-            shutil.move(fp, self.tmpdir_path)
-    
-    def __exit__(self, *_):
-        if self.tmpdir is None:
-            return
-        for fp in self.files:
-            shutil.move(self.tmpdir_path / fp.name, ModuleDir_Raw)
-        self.tmpdir.cleanup()
-
-
-@contextlib.contextmanager
-def tmp_replace_ctx(fp, orig, tmp):
-    orig_txt = fp.read_text()
-    assert orig_txt.count(orig) == 1
-    tmp_txt = orig_txt.replace(orig, tmp)
-    fp.write_text(tmp_txt)
-    try:
-        yield
-    finally:
-        fp.write_text(orig_txt)
-
-
-@contextlib.contextmanager
-def tmp_ctypesgen_pin():
-    
-    pin = os.environ.get("CTYPESGEN_PIN", None)
-    if not pin:
-        head_url = "https://api.github.com/repos/pypdfium2-team/ctypesgen/git/refs/heads/pypdfium2"
-        with url_request.urlopen(head_url) as rq:
-            content = rq.read().decode()
-        content = json.loads(content)
-        pin = content["object"]["sha"]
-        print(f"Resolved pypdfium2 ctypesgen HEAD to SHA {pin}", file=sys.stderr)
-    
-    base_txt = "ctypesgen @ git+https://github.com/pypdfium2-team/ctypesgen@"
-    ctx = tmp_replace_ctx(ProjectDir/"pyproject.toml", base_txt+"pypdfium2", base_txt+pin)
-    with ctx:
-        print(f"Wrote temporary pyproject.toml with ctypesgen pin", file=sys.stderr)
-        yield
-    print(f"Reset pyproject.toml", file=sys.stderr)
-
-
-class TmpCommitCtx:
-    
-    # Work around local conda `git_url` not including uncommitted changes
-    # In particular, this is used to transfer data files, so we can generate them externally and don't have to conda package ctypesgen.
-    
-    # use a tmp control file so we can also undo the commit in conda's isolated clone
-    FILE = CondaDir / "with_tmp_commit.txt"
-    
-    def __enter__(self):
-        # determine if there are any modified or new files
-        out = run_cmd(["git", "status", "--porcelain"], capture=True, cwd=ProjectDir)
-        self.have_mods = bool(out)
-        if self.have_mods:  # make tmp commit
-            self.FILE.touch()
-            run_cmd(["git", "add", "."], cwd=ProjectDir)
-            run_cmd(["git", "commit", "-m", "!!! tmp commit for conda-build", "-m", "make conda-build include uncommitted changes"], cwd=ProjectDir)
-    
-    @classmethod
-    def undo(cls):
-        # assuming FILE exists (promised by callers)
-        run_cmd(["git", "reset", "--soft", "HEAD^"], cwd=ProjectDir)
-        run_cmd(["git", "reset", cls.FILE], cwd=ProjectDir)
-        cls.FILE.unlink()
-    
-    def __exit__(self, *_):
-        if self.have_mods:  # pop tmp commit, if any
-            self.undo()
-
-
-class CondaExtPlatfiles:
-    
-    def __init__(self, emplace_func):
-        self.emplace_func = emplace_func
-    
-    def __enter__(self):
-        self.platfiles = self.emplace_func()
-        self.platfiles = [ModuleDir_Raw/f for f in self.platfiles]
-        run_cmd(["git", "add", "-f"] + [str(f) for f in self.platfiles], cwd=ProjectDir)
-    
-    def __exit__(self, *_):
-        run_cmd(["git", "reset"] + [str(f) for f in self.platfiles], cwd=ProjectDir)
-        for fp in self.platfiles:
-            fp.unlink()
-
-
-if __name__ == '__main__':
-    main()
diff --git a/setupsrc/pypdfium2_setup/emplace.py b/setupsrc/pypdfium2_setup/emplace.py
index 1dc93b0ae..c7ef31249 100644
--- a/setupsrc/pypdfium2_setup/emplace.py
+++ b/setupsrc/pypdfium2_setup/emplace.py
@@ -63,7 +63,7 @@ def prepare_setup(pl_name, pdfium_ver, use_v8):
         system = plat_to_system(pl_name)
         
         if pl_name == ExtPlats.sourcebuild:
-            # sourcebuild bindings are captured once and can't really be re-generated, hence keep them in the platform directory so they are not overwritten
+            # sourcebuild bindings are kept in the platform directory
             platfiles += [pl_dir/BindingsFN]
         else:
             platfiles += [DataDir_Bindings/BindingsFN]
diff --git a/setupsrc/pypdfium2_setup/packaging_base.py b/setupsrc/pypdfium2_setup/packaging_base.py
index 808a5139a..c396ddec1 100644
--- a/setupsrc/pypdfium2_setup/packaging_base.py
+++ b/setupsrc/pypdfium2_setup/packaging_base.py
@@ -51,9 +51,6 @@
 AR_ConfigFile   = AutoreleaseDir / "config.json"
 RefBindingsFile = AutoreleaseDir / BindingsFN
 
-CondaDir = ProjectDir / "conda"
-CondaRaw_BuildNumF = CondaDir / "raw" / "build_num.txt"
-
 RepositoryURL  = "https://github.com/pypdfium2-team/pypdfium2"
 PdfiumURL      = "https://pdfium.googlesource.com/pdfium"
 DepotToolsURL  = "https://chromium.googlesource.com/chromium/tools/depot_tools.git"
@@ -77,7 +74,6 @@ class ExtPlats:
     system = "system"
     sdist = "sdist"
 
-# TODO align with either python or google platform names?
 class PlatNames:
     # - Attribute names and values are expected to match
     # - Platform names are expected to start with the corresponding system name
@@ -115,12 +111,12 @@ class PlatNames:
     PlatNames.android_arm64:    "android-arm64",
 }
 
-# Capture the platforms we package wheels for
+# Capture the platforms we build wheels for
 WheelPlatforms = list(PdfiumBinariesMap.keys())
 
-# Additional platforms we don't currently package wheels for in craft_packages.py
+# Additional platforms we don't currently build wheels for in craft.py
 # To package these manually, you can do (in bash):
-# export PLATFORMS=(android_arm64 android_arm32 android_x64 android_x86)
+# export PLATFORMS=(android_arm32 android_x64 android_x86)
 # for PLAT in ${PLATFORMS[@]}; do echo $PLAT; ./run emplace $PLAT; PDFIUM_PLATFORM=$PLAT python3 -m build -wxn; done
 PdfiumBinariesMap.update({
     PlatNames.android_arm32: "android-arm",
@@ -137,12 +133,6 @@ class PlatNames:
 }
 
 
-@functools.lru_cache(maxsize=2)
-def run_conda_search(package, channel):
-    output = run_cmd(["conda", "search", "--json", package, "--override-channels", "-c", channel], cwd=None, capture=True)
-    return json.loads(output)[package]
-
-
 class PdfiumVer:
     
     scheme = namedtuple("PdfiumVer", ("major", "minor", "build", "patch"))
@@ -155,25 +145,6 @@ def get_latest():
         tag = git_ls.split("\t")[-1]
         return int( tag.split("/")[-1] )
     
-    @staticmethod
-    @functools.lru_cache(maxsize=2)
-    def _get_latest_conda_for(package, channel, v_func):
-        search = run_conda_search(package, channel)
-        search = sorted(search, key=lambda d: v_func(d["version"]), reverse=True)
-        result = v_func(search[0]["version"])
-        print(f"Resolved latest {channel}::{package} to {result}", file=sys.stderr)
-        return result
-    
-    def get_latest_conda_pdfium():
-        return PdfiumVer._get_latest_conda_for(
-            "pdfium-binaries", "bblanchon", lambda v: int(v.split(".")[2])
-        )
-    
-    def get_latest_conda_bindings():
-        return PdfiumVer._get_latest_conda_for(
-            "pypdfium2_raw", "pypdfium2-team", lambda v: int(v)
-        )
-    
     @classmethod
     def to_full(cls, v_short):