Skip to content

Commit 6a6d049

Browse files
committed
Remove pyston_gcc from make check
I don't think we regularly run make check anymore, and it's a pain to make sure the user has an up-to-date gcc (would need to come up with a good set of instructions for anyone on 12.04). So just remove it from make check for now.
1 parent b8cd6e6 commit 6a6d049

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

Makefile

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@ USE_DISTCC := 0
1717
ENABLE_VALGRIND := 0
1818

1919
GDB := gdb
20-
GCC_DIR := $(DEPS_DIR)/gcc-4.8.2-install
20+
# If you followed the old install instructions:
21+
# GCC_DIR := $(DEPS_DIR)/gcc-4.8.2-install
22+
GCC_DIR := /usr
2123
GTEST_DIR := $(DEPS_DIR)/gtest-1.7.0
2224

2325
USE_DEBUG_LIBUNWIND := 0
@@ -544,11 +546,6 @@ check:
544546

545547
$(MAKE) run_unittests ARGS=
546548

547-
@# Building in gcc mode is helpful to find various compiler-specific warnings.
548-
@# We've also discovered UB in our code from running in gcc mode, so try running it as well.
549-
$(MAKE) pyston_gcc
550-
$(PYTHON) $(TOOLS_DIR)/tester.py -R pyston_gcc -j$(TEST_THREADS) -k -a=-S $(TESTS_DIR) $(ARGS)
551-
552549
$(MAKE) pyston_release
553550
@# It can be useful to test release mode, since it actually exposes different functionality
554551
@# since we can make different decisions about which internal functions to inline or not.

0 commit comments

Comments
 (0)