fix: handle task callback correctly (#22)

The existing code would crash on calling the callback lambda for
a completed task because it takes `task` as parameter and our lambda
had no input. This change just passes discard that takes an element as
an argument. Discard is chosen over remove to ensure it won't raise
error (although it shouldn't happen).

Author: ali-behjati

example_publisher/providers/coin_gecko.py

@@ -30,7 +30,7 @@ def upd_products(self, product_symbols: List[Symbol]) -> None:
                 new_prices[id] = self._prices.get(id, None)
             else:
                 raise ValueError(
-                    f"{coin_gecko_product.symbol} not found in available products"
+                    f"{coin_gecko_product.symbol} not found in available products"  # noqa: E713
                 )
 
         self._prices = new_prices

example_publisher/pythd.py

@@ -43,13 +43,14 @@ def __init__(
         self.address = address
         self.server: Server = None
         self.on_notify_price_sched = on_notify_price_sched
-        self._notify_price_sched_tasks = set()
+        self._tasks = set()
 
     async def connect(self) -> Server:
         self.server = Server(self.address)
         self.server.notify_price_sched = self._notify_price_sched
         task = await self.server.ws_connect()
         task.add_done_callback(Pythd._on_connection_done)
+        self._tasks.add(task)
 
     @staticmethod
     def _on_connection_done(task):
@@ -73,8 +74,8 @@ def _notify_price_sched(self, subscription: int) -> None:
         task = asyncio.get_event_loop().create_task(
             self.on_notify_price_sched(subscription)
         )
-        self._notify_price_sched_tasks.add(task)
-        task.add_done_callback(lambda: self._notify_price_sched_tasks.remove(task))
+        self._tasks.add(task)
+        task.add_done_callback(self._tasks.discard)
 
     async def all_products(self) -> List[Product]:
         result = await self.server.get_product_list()

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "example-publisher"
-version = "1.0.2"
+version = "1.0.3"
 description = ""
 authors = []
 license = "Apache-2"