Use ABC instead of Protocol (#12)

Author: ali-behjati

publisher/provider.py

@@ -1,5 +1,7 @@
+from abc import ABC, abstractmethod
+import asyncio
 from dataclasses import dataclass
-from typing import List, Optional, Protocol
+from typing import List, Optional
 
 Symbol = str
 
@@ -10,12 +12,18 @@ class Price:
     conf: float
 
 
-class Provider(Protocol):
+class Provider(ABC):
+    @abstractmethod
     def upd_products(self, product_symbols: List[Symbol]):
         ...
 
-    def start(self):
+    def start(self) -> None:
+        asyncio.create_task(self._update_loop())
+
+    @abstractmethod
+    async def _update_loop(self):
         ...
 
+    @abstractmethod
     def latest_price(self, symbol: Symbol) -> Optional[Price]:
         ...

publisher/providers/coin_gecko.py

@@ -22,9 +22,6 @@ def __init__(self, config: CoinGeckoConfig) -> None:
         }
         self._config = config
 
-    def start(self) -> None:
-        asyncio.create_task(self._update_loop())
-
     def upd_products(self, product_symbols: List[Symbol]) -> None:
         new_prices = {}
         for coin_gecko_product in self._config.products:

publisher/providers/pyth_replicator.py

@@ -29,10 +29,7 @@ def __init__(self, config: PythReplicatorConfig) -> None:
             str, Tuple[float | None, float | None, UnixTimestamp | None]
         ] = {}
 
-    def start(self) -> None:
-        asyncio.create_task(self._ws_loop())
-
-    async def _ws_loop(self) -> None:
+    async def _update_loop(self) -> None:
         self._ws = self._client.create_watch_session()
         log.info("Creating Pyth replicator WS")
 

setup.py

@@ -2,7 +2,7 @@
 
 setup(
     name="example-publisher",
-    version="0.1.0",
+    version="0.1.1",
     author="Pyth Data Association",
     author_email="",
     packages=find_packages(exclude=["tests"]),