Skip to content

ffmpeg_downloader.installed doesn't check if ffmpeg is installed anywhere else on the system. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FlorianEagox opened this issue Mar 18, 2024 · 1 comment

Comments

@FlorianEagox
Copy link

The ffmpeg_downloader.installed() function only seems to check if ffmpeg is installed in the dir this program would install it in, but it doesn't check if it's already in the system path or callable globally from the CLI.

@tikuma-lsuhsc
Copy link
Contributor

Right. Because this project was meant to be a cli command, I figured the user would/should first try ffmpeg command before ffdl to see if the system already has FFmpeg installed. Let me sit on it for a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants