Test failures with Python 3.14: segfault and AssertionErrors in test_local_time_positive_integer/test_local_time_negative_integer

[befeleme]

• I am on the latest Pendulum version.

• I have searched the issues of this repo and believe that this is not a duplicate.

• OS version and name: Fedora Linux 43

• Pendulum version: 3.1.0

Issue

Hi, I'm trying to build pendulum for Fedora Linux with Python 3.14.0b1.
I see two issues happening there.

test_from_format results in Segmentation fault for two parameters:

        ("1234567890", "X", "2009-02-13T23:31:30+00:00", None),
        ("1234567890123", "x", "2009-02-13T23:31:30.123000+00:00", None),

When removed these, the test suite runs successfully, but with two more failures:

__________________________________________ test_local_time_positive_integer ___________________________________________

    def test_local_time_positive_integer():
        d = pendulum.datetime(2016, 8, 7, 12, 34, 56, 123456)
    
        t = local_time(d.int_timestamp, 0, d.microsecond)
>       assert d.year == t[0]
E       AssertionError: assert 2016 == 8
E        +  where 2016 = DateTime(2016, 8, 7, 12, 34, 56, 123456, tzinfo=Timezone('UTC')).year

tests/helpers/test_local_time.py:12: AssertionError
__________________________________________ test_local_time_negative_integer ___________________________________________

    def test_local_time_negative_integer():
        d = pendulum.datetime(1951, 8, 7, 12, 34, 56, 123456)
    
        t = local_time(d.int_timestamp, 0, d.microsecond)
>       assert d.year == t[0]
E       AssertionError: assert 1951 == 8
E        +  where 1951 = DateTime(1951, 8, 7, 12, 34, 56, 123456, tzinfo=Timezone('UTC')).year

[musicinmybrain]

Working on the rust-pyo3_* compat packages in Fedora, @decathorpe has written:

so, it looks like ABI changes in Python 3.14 affect some packages that use the PyO3 Rust bindings when not using the "Limited ABI" - there are crashes and segfaults in the PyO3 test suite in PyO3 <0.25 (i.e. 0.22, 0.23, and 0.24) - this affects a rather large number of packages, and I'm not sure what to do about those, since they might just be silently broken
[…]
yes, the packages compile fine, but might crash at runtime. it depends on whether they use any functions or structs for which the ABI has changed
[…]
(this is usually prevented by checks in PyO3 but we have disabled those on request […])
[…]
(so basic import checks might catch this, if importing the modules already calls affected code paths - or they might not, if not)

These do look suspiciously like ABI-incompatibility issues. One is a segfault, obviously, and for the local_time tests, they are checking against

pendulum/rust/src/helpers.rs

Lines 46 to 50 in fc386be

	pub fn local_time(
	unix_time: f64,
	utc_offset: isize,
	microsecond: usize,
	) -> (usize, usize, usize, usize, usize, usize, usize) {

[…]

pendulum/rust/src/helpers.rs

Lines 121 to 122 in fc386be

	(year, month, day, hour, minute, second, microsecond)
	}

and the test is calling that from Python, extracting the first element ([0]), and getting the month when it should have gotten the year:

__________________________________________ test_local_time_positive_integer ___________________________________________

    def test_local_time_positive_integer():
        d = pendulum.datetime(2016, 8, 7, 12, 34, 56, 123456)
    
        t = local_time(d.int_timestamp, 0, d.microsecond)
>       assert d.year == t[0]
E       AssertionError: assert 2016 == 8
E        +  where 2016 = DateTime(2016, 8, 7, 12, 34, 56, 123456, tzinfo=Timezone('UTC')).year

tests/helpers/test_local_time.py:12: AssertionError

I suspect that these Python 3.14 issues can only be fixed by updating the PyO3 dependency to 0.25. I would offer a PR, but I haven’t managed to understand how to migrate the .to_object(…) calls in src/python/parsing.rs according to https://pyo3.rs/v0.23.0/migration#intopyobject-manual-implementation.