Skip to content

Conversation

@ArmRyan
Copy link
Collaborator

@ArmRyan ArmRyan commented Nov 25, 2025

Add clone to tosa identity op factory. Only present with using
_skip_dim_order flag.

Change-Id: Ieda1990fa2d1a9627d821db122d201c032dc517b

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

 Add clone to tosa identity op factory. Only present with using
 _skip_dim_order flag.

Signed-off-by: Ryan O'Shea <[email protected]>
Change-Id: Ieda1990fa2d1a9627d821db122d201c032dc517b
@ArmRyan ArmRyan requested a review from digantdesai as a code owner November 25, 2025 15:51
@ArmRyan ArmRyan added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Nov 25, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15980

Note: Links to docs will display an error until the docs builds have been completed.

❗ 2 Active SEVs

There are 2 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 25, 2025
@oscarandersson8218
Copy link
Collaborator

@AdrianLundell can you have a look at this and make sure that this is aligned with our dim-order/memory-format handling?

@AdrianLundell
Copy link
Collaborator

I have a few questions:

  1. How is the memory_format arg of clone handled here?
  2. Why are we supporting skip_dim_order=True? I was under the impression that it isn't supposed to be used.
  3. Why do we have two ways of handling noops? (remove_noop_pass vs ops_identity, I prefer the pass here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants