Skip to content

Commit 7b77ac9

Browse files
committed
[CI] Fix envnames in SOTA tests
ghstack-source-id: 1425e8ade1b452621d1c98c86888ea724f6b99e6 Pull-Request-resolved: #2921
1 parent 76306b3 commit 7b77ac9

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

.github/unittest/linux_sota/scripts/environment.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,5 +29,5 @@ dependencies:
2929
- coverage
3030
- vmas
3131
- transformers
32-
- gym[atari]
33-
- gym[accept-rom-license]
32+
- gym[atari,accept-rom-license,ale-py]
33+
- gymnasium[atari,ale-py]>=1.1.0

.github/unittest/linux_sota/scripts/run_all.sh

-1
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,6 @@ python -c """import gym;import d4rl"""
111111

112112
# install ale-py: manylinux names are broken for CentOS so we need to manually download and
113113
# rename them
114-
pip install "gymnasium[atari]>=1.1.0"
115114

116115
# ============================================================================================ #
117116
# ================================ PyTorch & TorchRL ========================================= #

.github/unittest/linux_sota/scripts/test_sota.py

+4
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
collector.frames_per_batch=20 \
4040
collector.num_workers=1 \
4141
logger.backend= \
42+
env.env_name=ALE/Pong-v5 \
4243
logger.test_interval=10
4344
""",
4445
"ppo_mujoco": """python sota-implementations/ppo/ppo_mujoco.py \
@@ -56,6 +57,7 @@
5657
loss.mini_batch_size=20 \
5758
loss.ppo_epochs=2 \
5859
logger.backend= \
60+
env.env_name=ALE/Pong-v5 \
5961
logger.test_interval=10
6062
""",
6163
"ddpg": """python sota-implementations/ddpg/ddpg.py \
@@ -82,6 +84,7 @@
8284
collector.frames_per_batch=20 \
8385
loss.mini_batch_size=20 \
8486
logger.backend= \
87+
env.env_name=ALE/Pong-v5 \
8588
logger.test_interval=40
8689
""",
8790
"dqn_atari": """python sota-implementations/dqn/dqn_atari.py \
@@ -91,6 +94,7 @@
9194
buffer.batch_size=10 \
9295
loss.num_updates=1 \
9396
logger.backend= \
97+
env.env_name=ALE/Pong-v5 \
9498
buffer.buffer_size=120
9599
""",
96100
"discrete_cql_online": """python sota-implementations/cql/discrete_cql_online.py \

0 commit comments

Comments
 (0)