Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] broken link in docs #2174

Closed
ikamensh opened this issue May 28, 2024 · 3 comments · Fixed by #2197
Closed

[BUG] broken link in docs #2174

ikamensh opened this issue May 28, 2024 · 3 comments · Fixed by #2197
Assignees
Labels
bug Something isn't working

Comments

@ikamensh
Copy link

Describe the bug

Docs https://pytorch.org/rl/stable/tutorials/coding_ppo.html have broken link for "coding_ppo". When clicking on open in colab, this opens:
"""
Notebook not found
There was an error loading this notebook. Ensure that the file is accessible and try again.
https://github.com/pytorch/rl/blob/gh-pages/_downloads/c4cc1ccac40ca535b79628b7eb0bbe18/coding_ppo.py
Fetch for https://api.github.com/repos/pytorch/rl/contents/_downloads/c4cc1ccac40ca535b79628b7eb0bbe18?per_page=100&ref=gh-pages failed: {
"""

This link worked though: https://colab.research.google.com/github/pytorch/rl/blob/gh-pages/0.4/_downloads/e2a5193e019585d9cfa26d3eebfd8be3/coding_ppo.ipynb

@ikamensh ikamensh added the bug Something isn't working label May 28, 2024
@vmoens
Copy link
Contributor

vmoens commented May 29, 2024

Yep unfortunately the automated link to the colabs are broken. Maybe @svekars can help?

@matteobettini
Copy link
Contributor

Duplicate of #2134

@vmoens vmoens linked a pull request Jun 3, 2024 that will close this issue
@vmoens vmoens reopened this Jun 7, 2024
@vmoens
Copy link
Contributor

vmoens commented Jul 4, 2024

Closed by #2268

@vmoens vmoens closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants