Skip to content

Commit 0f81544

Browse files
aivanoufacebook-github-bot
authored andcommitted
Remove ray scheduler (#350)
Summary: Pull Request resolved: #350 Remove ray scheduler from registry for now since it is not ready Reviewed By: d4l3k Differential Revision: D32473942 fbshipit-source-id: f1a20954f652afe76610295a6aa827b35e15acc3
1 parent 634ce7e commit 0f81544

File tree

2 files changed

+11
-15
lines changed

2 files changed

+11
-15
lines changed

torchx/schedulers/__init__.py

-4
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import torchx.schedulers.docker_scheduler as docker_scheduler
1111
import torchx.schedulers.kubernetes_scheduler as kubernetes_scheduler
1212
import torchx.schedulers.local_scheduler as local_scheduler
13-
import torchx.schedulers.ray_scheduler as ray_scheduler
1413
import torchx.schedulers.slurm_scheduler as slurm_scheduler
1514
from torchx.schedulers.api import Scheduler
1615
from torchx.specs.api import SchedulerBackend
@@ -37,9 +36,6 @@ def get_scheduler_factories() -> Dict[str, SchedulerFactory]:
3736
"kubernetes": kubernetes_scheduler.create_scheduler,
3837
}
3938

40-
if ray_scheduler.has_ray():
41-
default_schedulers["ray"] = ray_scheduler.create_scheduler
42-
4339
return load_group(
4440
"torchx.schedulers",
4541
default=default_schedulers,

torchx/schedulers/test/ray_scheduler_test.py

+11-11
Original file line numberDiff line numberDiff line change
@@ -6,31 +6,31 @@
66

77
from contextlib import contextmanager
88
from dataclasses import dataclass
9-
from typing import Any, Dict, Iterator, Type, cast
9+
from typing import Any, Dict, Iterator, Type
1010
from unittest import TestCase
1111
from unittest.mock import patch
1212

13-
from torchx.schedulers import get_schedulers
1413
from torchx.schedulers.ray_scheduler import RayScheduler, _logger, has_ray
1514
from torchx.specs import AppDef, CfgVal, Resource, Role, runopts
1615

1716

1817
if has_ray():
1918

20-
class RaySchedulerRegistryTest(TestCase):
21-
def test_get_schedulers_returns_ray_scheduler(self) -> None:
22-
schedulers = get_schedulers("test_session")
19+
# TODO(aivanou): enable after 0.1.1 release
20+
# class RaySchedulerRegistryTest(TestCase):
21+
# def test_get_schedulers_returns_ray_scheduler(self) -> None:
22+
# schedulers = get_schedulers("test_session")
2323

24-
self.assertIn("ray", schedulers)
24+
# self.assertIn("ray", schedulers)
2525

26-
scheduler = schedulers["ray"]
26+
# scheduler = schedulers["ray"]
2727

28-
self.assertIsInstance(scheduler, RayScheduler)
28+
# self.assertIsInstance(scheduler, RayScheduler)
2929

30-
ray_scheduler = cast(RayScheduler, scheduler)
30+
# ray_scheduler = cast(RayScheduler, scheduler)
3131

32-
self.assertEqual(ray_scheduler.backend, "ray")
33-
self.assertEqual(ray_scheduler.session_name, "test_session")
32+
# self.assertEqual(ray_scheduler.backend, "ray")
33+
# self.assertEqual(ray_scheduler.session_name, "test_session")
3434

3535
class RaySchedulerTest(TestCase):
3636
def setUp(self) -> None:

0 commit comments

Comments
 (0)