Skip to content

Commit e233023

Browse files
Daniel Ohayonfacebook-github-bot
authored andcommitted
update pyre nightly version (#1076)
Summary: Pyre signal is failing on github because the nightly version that we're pinned to is no longer available in pip Differential Revision: D75791451
1 parent 24dc0d5 commit e233023

File tree

11 files changed

+13
-27
lines changed

11 files changed

+13
-27
lines changed

.pyre_configuration

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,5 @@
1818
"stubs"
1919
],
2020
"strict": true,
21-
"version": "0.0.101732536891"
21+
"version": "0.0.101748862749"
2222
}

scripts/kfpint.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ def run_pipeline(build: BuildInfo, pipeline_file: str) -> object:
209209

210210

211211
def wait_for_pipeline(
212-
resp: Any, # pyre-fixme: KFP doesn't have a response type
212+
resp: Any, # KFP response object
213213
) -> None:
214214
print(f"{resp.run_id} - waiting for completion")
215215
result = resp.wait_for_run_completion(

torchx/cli/argparse_util.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ def __init__(
3535
dest: str,
3636
option_strings: Sequence[Text],
3737
required: bool = False,
38-
# pyre-ignore[2] declared as Any in superclass Action
3938
default: Any = None,
4039
**kwargs: Any,
4140
) -> None:
@@ -69,7 +68,7 @@ def __call__(
6968
self,
7069
parser: ArgumentParser,
7170
namespace: Namespace,
72-
values: Any, # pyre-ignore[2] declared as Any in superclass Action
71+
values: Any,
7372
option_string: Optional[str] = None,
7473
) -> None:
7574
if option_string is not None:
@@ -93,7 +92,6 @@ def __init__(
9392
dest: str,
9493
option_strings: Sequence[Text],
9594
required: bool = False,
96-
# pyre-ignore[2] declared as Any in superclass Action
9795
default: Any = None,
9896
**kwargs: Any,
9997
) -> None:

torchx/schedulers/aws_batch_scheduler.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -421,9 +421,7 @@ class AWSBatchScheduler(
421421
def __init__(
422422
self,
423423
session_name: str,
424-
# pyre-fixme[2]: Parameter annotation cannot be `Any`.
425424
client: Optional[Any] = None,
426-
# pyre-fixme[2]: Parameter annotation cannot be `Any`.
427425
log_client: Optional[Any] = None,
428426
docker_client: Optional["DockerClient"] = None,
429427
) -> None:
@@ -432,18 +430,13 @@ def __init__(
432430

433431
# pyre-fixme[4]: Attribute annotation cannot be `Any`.
434432
self.__client = client
435-
# pyre-fixme[4]: Attribute annotation cannot be `Any`.
436-
self.__log_client = log_client
437433

438-
@property
439-
# pyre-fixme[3]: Return annotation cannot be `Any`.
440434
def _client(self) -> Any:
441435
if self.__client:
442436
return self.__client
443437
return _local_session().client("batch")
444438

445439
@property
446-
# pyre-fixme[3]: Return annotation cannot be `Any`.
447440
def _log_client(self) -> Any:
448441
if self.__log_client:
449442
return self.__log_client
@@ -833,9 +826,7 @@ def _stream_events(
833826

834827
def create_scheduler(
835828
session_name: str,
836-
# pyre-fixme[2]: Parameter annotation cannot be `Any`.
837829
client: Optional[Any] = None,
838-
# pyre-fixme[2]: Parameter annotation cannot be `Any`.
839830
log_client: Optional[Any] = None,
840831
docker_client: Optional["DockerClient"] = None,
841832
**kwargs: object,

torchx/schedulers/aws_sagemaker_scheduler.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,20 +197,23 @@ class AWSSageMakerScheduler(
197197
def __init__(
198198
self,
199199
session_name: str,
200-
client: Optional[Any] = None, # pyre-ignore[2]
200+
client: Optional[Any] = None,
201201
docker_client: Optional["DockerClient"] = None,
202202
) -> None:
203203
super().__init__("aws_sagemaker", session_name, docker_client=docker_client)
204204
# pyre-fixme[4]: Attribute annotation cannot be `Any`.
205205
self.__client = client
206206

207207
@property
208-
# pyre-fixme[3]: Return annotation cannot be `Any`.
209208
def _client(self) -> Any:
210209
if self.__client:
211210
return self.__client
212211
return _local_session().client("sagemaker")
213212

213+
@property
214+
def _client(self) -> Any:
215+
return _local_session().client("sagemaker")
216+
214217
def schedule(self, dryrun_info: AppDryRunInfo[AWSSageMakerJob]) -> str:
215218
cfg = dryrun_info._cfg
216219
assert cfg is not None, f"{dryrun_info} missing cfg"

torchx/schedulers/test/ray_scheduler_test.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,6 @@ def test_submit_dryrun_raises_error_if_cluster_config_file_is_not_found(
216216
):
217217
self._scheduler._submit_dryrun(self._app_def, self._run_cfg)
218218

219-
# pyre-ignore[2]: Parameter `value` must have a type other than `Any`
220219
def _assert_config_value(self, name: str, value: Any, type_name: str) -> None:
221220
# pyre-fixme: TypedDict indexes by string literal
222221
self._run_cfg[name] = value

torchx/specs/api.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,6 @@ class Role:
391391
)
392392
overrides: Dict[str, Any] = field(default_factory=dict)
393393

394-
# pyre-ignore
395394
def __getattribute__(self, attrname: str) -> Any:
396395
if attrname == "overrides":
397396
return super().__getattribute__(attrname)

torchx/specs/builders.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def _create_args_parser(
3131

3232

3333
def _create_args_parser_from_parameters(
34-
cmpnt_fn: Callable[..., Any], # pyre-ignore[2]
34+
cmpnt_fn: Callable[..., Any],
3535
parameters: Mapping[str, inspect.Parameter],
3636
cmpnt_defaults: Optional[Dict[str, str]] = None,
3737
config: Optional[Dict[str, Any]] = None,
@@ -112,7 +112,7 @@ def _merge_config_values_with_args(
112112

113113

114114
def parse_args(
115-
cmpnt_fn: Callable[..., Any], # pyre-ignore[2]
115+
cmpnt_fn: Callable[..., Any],
116116
cmpnt_args: List[str],
117117
cmpnt_defaults: Optional[Dict[str, Any]] = None,
118118
config: Optional[Dict[str, Any]] = None,
@@ -141,7 +141,7 @@ def parse_args(
141141

142142

143143
def materialize_appdef(
144-
cmpnt_fn: Callable[..., Any], # pyre-ignore[2]
144+
cmpnt_fn: Callable[..., Any],
145145
cmpnt_args: List[str],
146146
cmpnt_defaults: Optional[Dict[str, Any]] = None,
147147
config: Optional[Dict[str, Any]] = None,

torchx/specs/finder.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ class _Component:
5555
description: str
5656
fn_name: str
5757

58-
# pyre-ignore[4] TODO temporary until PipelineDef is decoupled and can be exposed as type to OSS
5958
fn: Callable[..., Any]
6059

6160
validation_errors: List[str]

torchx/specs/test/builders_test.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,6 @@ def test_single_letter(self) -> None:
428428
"arg2",
429429
)
430430

431-
# pyre-ignore[3]
432431
def _get_argument_help(
433432
self, parser: argparse.ArgumentParser, name: str
434433
) -> Optional[Tuple[str, Any]]:

0 commit comments

Comments
 (0)