Merge branch 'develop' of https://github.com/ODIQueensland/data-curator into develop

Author: Matthew Mulholland

test/features/.nav

@@ -14,14 +14,12 @@
   - save-as-comma-separated-file.feature
   - save-as-tab-separated-file.feature
   - save-as-semi-colon-separated-file.feature
-  - close-tab.feature
 - edit:
   - undo.feature
   - redo.feature
   - cut.feature
   - copy.feature
   - paste.feature
-  - select-all.feature
   - insert-row-above.feature
   - insert-row-below.feature
   - insert-column-before.feature
@@ -32,8 +30,12 @@
   - find.feature
   - replace-in-column.feature
   - replace-in-table.feature
+- find:
+  - find.feature
+  - replace.feature
 - tools:
   - freeze-header-row.feature
+  - case-sensitive-header-row.feature
   - guess-column-properties.feature
   - set-column-properties.feature
   - set-table-properties.feature
@@ -82,15 +84,12 @@
   - close-all-tabs.feature
   - print.feature
   - read-only-mode.feature
-  - find.feature
   - data-quality-information.feature
   - sample-data-quality-information.md
   - set-view-properties.feature
   - export-closed-datapackage.feature
 - drafts:
   - save-all.feature
-  - replace-in-table.feature
-  - replace-in-column.feature
   - sort-column.feature
   - filter-column.feature
   - validate-as-you-type.feature

test/features/file/close-tab.feature renamed to test/features/backlog/close-tab.feature

@@ -1,3 +1,5 @@
+@backlog
+
 Feature: Check for update
   As a Data Packager or Data Consumer
   I want to update to the lastest version of the application

test/features/help/help.feature renamed to test/features/backlog/help.feature

@@ -1,3 +1,5 @@
+@backlog
+
 Feature: Set Preferences
   As a Data Packager
   I want to set default values and behaviours

test/features/edit/select-all.feature renamed to test/features/backlog/select-all.feature

@@ -1,12 +1,9 @@
-@backlog
-
-Feature: Find
+Feature: Find data
   As a User
   I want to find data within the current column or across the current table
-  So that I can if/where the data exists
+  So that I can determine if the data exists and correct it if necessary
 
   "Find" can be invoked using a toolbar, menu item or keyboard shortcut
-  "Find" can be dismissed by pressing a close button of keyboard shortcut
   "Find next" and "Find previous" can be invoked using a using a menu item, button or keyboard shortcut
 
   Rules:
@@ -17,37 +14,18 @@ Feature: Find
   - When "Find previous" is invoked but no values are found on reaching the start of the column/table, inform the user
 
   Notes:
-  - https://docs.handsontable.com/0.34.4/demo-searching.html 
-
-  Scenario: Open Find
-    Given I have opened Data Curator
-    And the cursor is in a column
-    When I invoke "Find"
-    Then Show the Find panel
-    And prompt for a value to find and search constraints
-
-  Scenario: Close Find
-    Given I have opened Data Curator
-    And I have opened the Find panel
-    When I dismiss "Find"
-    Then close the Find Panel
+  - https://docs.handsontable.com/0.34.4/demo-searching.html
 
   Scenario: Find next
     Given I have opened Data Curator
-    And I have opened the Find panel
-    And data tab is active
-    And provided a value to search for and search constraints
+    And provided a value to find and optionally search constraints
     When I invoke "Find next"
-    Then find the next value after the current active cell that matches that value within the search constraints
+    Then find the next value after the current active cell that matches that value and within the search constraints
     And highlight the found value
-    And provide an information message
 
   Scenario: Find previous
     Given I have opened Data Curator
-    And I have opened the Find panel
-    And a data tab is active
-    And provided a value to search for and search constraints
+    And provided a value to find for and search constraints
     When I invoke "Find previous"
-    Then find the previous value before the current active cell that matches that value within the search constraints
+    Then find the previous value before the current active cell that matches that value and within the search constraints
     And highlight the found value
-    And provide an information message

test/features/data_curator/check-for-update.feature

@@ -0,0 +1,32 @@
+Feature: Replace data
+  As a Data Packager
+  I want to replace one or more values that have been found
+  So that I correct data errors quickly
+
+  Scenario: Replace in column
+    Given I have opened Data Curator
+    And I have found one or more values using the Find Next or Find Previous command
+    And I have provided a replacement value
+    When I select "Replace in column"
+    Then replace the first value found in the column after the current cursor position with the replacement value
+
+  Scenario: Replace All in column
+    Given I have opened Data Curator
+    And I have found one or more values using the Find Next or Find Previous command
+    And I have provided a replacement value
+    When I select "Replace All in column" from the menu
+    Then replace the all found values in the column with the replacement value
+
+  Scenario: Replace in table
+    Given I have opened Data Curator
+    And I have found one or more values using the Find Next or Find Previous command
+    And I have provided a replacement value
+    When I select "Replace in table"
+    Then replace the first value found in the table after the current cursor position with the replacement value
+
+  Scenario: Replace All in table
+    Given I have opened Data Curator
+    And I have found one or more values using the Find Next or Find Previous command
+    And I have provided a replacement value
+    When I select "Replace All in table" from the menu
+    Then replace the all found values in the table with the replacement value

test/features/data_curator/set-preferences.feature

@@ -0,0 +1,21 @@
+Feature: Set Case Sensitive Header Row
+  As a Data Packager
+  I want character case be considered in determining the uniqueness of the header row
+  So that I have increased flexibility in naming column headers
+
+  Case Sensitive Header Row can be invoked by a checkbox menu item
+  By default the menu item is unchecked
+
+  Scenario: Set Case Sensitive Header Row
+    Given I have opened Data Curator
+    When I invoke "Case Sensitive Header Row"
+    Then check the menu item
+    And consider case in determining the uniqueness of the header row
+    And set the 'caseSensitiveHeader' in the CSV Dialect to 'true'
+
+  Scenario: Unset Case Sensitive Header Row
+    Given I have opened Data Curator
+    When I disable "Case Sensitive Header Row"
+    Then uncheck the menu item
+    And don't consider case in determining the uniqueness of the header row
+    And set the 'caseSensitiveHeader' in the CSV Dialect to 'false'

test/features/edit/replace-in-column.feature

@@ -1,3 +1,5 @@
+@backlog
+
 Feature: Create Constraint from Column
   As a Data Packager
   I want to find all unique values in a column of data

test/features/edit/replace-in-table.feature

@@ -1,3 +1,5 @@
+@backlog
+
 Feature: Create Lookup Table from Column
   As a Data Packager
   I want to quickly make a look-up table

test/features/edit/find.feature renamed to test/features/find/find.feature

@@ -1,4 +1,4 @@
-Feature: Toggle Header Row
+Feature: Set Header Row
   As a Data Packager
   I want to freeze the header row (the first row)
   So that the data is not included in "Sort Column" command

test/features/find/replace.feature

@@ -1,7 +1,7 @@
 Feature: Validate Table
   As a Data Packager
   I want to validate the data for common errors and against the schema defined by the column properties
-  So that I can correct errors and only share validated data with Data Consumers
+  So that I can correct errors and share validated data with Data Consumers
 
   The "Validate Table" command can be invoked using a menu item, toolbar button or keyboard shortcut
 
@@ -14,7 +14,7 @@ Feature: Validate Table
 
   Schema validation checks include the:
   - data is the same 'type' and 'format' as defined in the column properties, ignoring 'missing values'
-  - data conforms with the 'contraints'
+  - data conforms with the 'constraints'
   - 'foreign key' relationships to one or more columns in:
     - the same table
     - the same data package
@@ -34,5 +34,40 @@ Feature: Validate Table
     Then assemble the Table Schema if avaliable from Column Properties
     And check for structural data errors
     And validate the data against the available schema
-    And display error messages
+    And display error messages in a panel
     And highlight errors in the relevant cells, rows or columns
+
+  Scenario: Pop out validation error messages
+    Given I have Validated a Table
+    And errors have been detected and displayed in a panel
+    When I invoke the "Pop out validation error messages" command
+    Then display the error messages in a table in a separate window
+    And show a count of the number of errors detected
+    And close the error message panel
+
+  Scenario: Sort validation error messages
+    Given I have Validated a Table
+    And errors have been detected and displayed error messages in a table in a separate window
+    When I invoke the sort column command
+    Then sort the error messages by that columns
+
+  Scenario: Filter validation error messages
+    Given I have Validated a Table
+    And errors have been detected and displayed error messages in a table in a separate window
+    When I invoke the filter column command
+    And provide a filter value(s)
+    Then only display the error messages that meet the filter criteria
+
+  Scenario: Link to error cell
+    Given I have Validated a Table
+    And errors have been detected and displayed
+    When I click the error message
+    Then move the cursor to the associated cell in table
+
+  Scenario: Write residual error to provenance information
+    Given I have Validated a Table
+    And errors have been detected and displayed error messages in a table in a separate window
+    When I invoke the "write errors to provenance information" command
+    Then append a heading "### Known Data Errors" to the end of the provenance information
+    And append a paragraph "This data is published with the following {count} data errors. Other errors may be present and could be detected after these errors are resolved." to the end of the provenance information
+    And append each error message as a bullet item to the end of the provenance information