Add plugin mode

Author: marschattha

qlty-check/src/planner.rs

@@ -19,6 +19,7 @@ use qlty_analysis::git::{compute_upstream, DiffLineFilter};
 use qlty_analysis::workspace_entries::TargetMode;
 use qlty_config::config::issue_transformer::IssueTransformer;
 use qlty_config::config::{DriverType, Match, PluginDef, Set, Triage};
+use qlty_config::config::{IssueMode, PluginMode};
 use qlty_config::{QltyConfig, Workspace};
 use qlty_types::analysis::v1::ExecutionVerb;
 use rayon::prelude::*;
@@ -292,7 +293,12 @@ impl Planner {
                     set: Set {
                         level: issue_override.level.clone(),
                         category: issue_override.category.clone(),
-                        mode: issue_override.mode,
+                        mode: issue_override.mode.map(|m| match m {
+                            IssueMode::Block => PluginMode::Block,
+                            IssueMode::Comment => PluginMode::Comment,
+                            IssueMode::Monitor => PluginMode::Monitor,
+                            IssueMode::Disabled => PluginMode::Monitor, // Mapping Disabled to Monitor as closest equivalent
+                        }),
                         ..Default::default()
                     },
                     _match: Match {

qlty-config/src/config.rs

@@ -26,7 +26,7 @@ pub use plugin::{
     CheckTrigger, DriverBatchBy, DriverDef, DriverType, EnabledPlugin, ExtraPackage,
     InvocationDirectoryDef, InvocationDirectoryType, IssueMode, OutputDestination, OutputFormat,
     OutputMissing, PackageFileCandidate, Platform, PluginDef, PluginEnvironment, PluginFetch,
-    Runtime, SuggestionMode, TargetDef, TargetType,
+    PluginMode, Runtime, SuggestionMode, TargetDef, TargetType,
 };
 pub use release::ReleaseDef;
 pub use source::SourceDef;

qlty-config/src/config/plugin.rs

@@ -736,6 +736,27 @@ impl PluginFetch {
     }
 }
 
+#[derive(Debug, Serialize, Deserialize, Clone, Copy, Default, PartialEq, JsonSchema)]
+pub enum PluginMode {
+    #[default]
+    #[serde(rename = "block")]
+    Block = 1,
+    #[serde(rename = "comment")]
+    Comment = 2,
+    #[serde(rename = "monitor")]
+    Monitor = 3,
+}
+
+impl PluginMode {
+    pub fn to_str(&self) -> &'static str {
+        match self {
+            PluginMode::Block => "block",
+            PluginMode::Comment => "comment",
+            PluginMode::Monitor => "monitor",
+        }
+    }
+}
+
 #[derive(Debug, Serialize, Deserialize, Clone, Copy, Default, PartialEq, JsonSchema)]
 pub enum IssueMode {
     #[default]

qlty-config/src/config/triage.rs

@@ -1,5 +1,5 @@
 use super::ignore::is_rule_issue_match;
-use super::IssueMode;
+use super::plugin::PluginMode;
 use crate::config::issue_transformer::IssueTransformer;
 use globset::{Glob, GlobSet, GlobSetBuilder};
 use qlty_types::category_from_str;
@@ -43,7 +43,7 @@ pub struct Set {
     pub category: Option<String>,
 
     #[serde(default)]
-    pub mode: Option<IssueMode>,
+    pub mode: Option<PluginMode>,
 
     #[serde(default)]
     pub ignored: bool,